leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix: validate owner/repo split in create_issue.html before form submission #30

New Issue
Closed
opened 2026-03-26 12:22:19 +00:00 by AI-Manager · 5 comments
AI-Manager commented 2026-03-26 12:22:19 +00:00
Owner
Copy Link
Copy Source

Description

The create_issue.html template uses a combined owner_repo select (e.g. leeworks-agents/gitea-mobile) and splits it into separate owner and repo hidden fields via JavaScript on the change event. However, there is no client-side validation to ensure the user has actually selected a repository before submitting — if the user taps "Create Issue" without selecting a repo, the form submits with empty owner and repo fields, causing a 400 error from the server with no helpful message.

Additionally, the POST /issues handler needs to gracefully handle the HTMX error response (currently it returns a plain-text 400, not an inline error fragment).

What to Do

  1. In create_issue.html, add a required attribute and validation:

    • Change the owner_repo select to also fire the split logic on form submit
    • Add a visible error message <div id="form-error" class="empty"></div> that HTMX can target on 4xx responses
    • Use hx-on:htmx:response-error to display error text inline

  2. In internal/handlers/handlers.go CreateIssue(), when returning 400 errors, check for HX-Request and return an HTML fragment instead of plain text:

    if isHTMX(r) {
  w.Header().Set("Content-Type", "text/html")
  http.Error(w, `<span class="empty">owner, repo, and title are required</span>`, http.StatusBadRequest)
  return
}

  3. Add a test case in handlers_test.go for the missing-owner 400 response.

Acceptance Criteria

  • Submitting the form without selecting a repo shows an inline error message (not a blank 400 page)
  • The owner and repo hidden fields are always populated before submission
  • POST /issues with missing owner/repo returns an HTMX-friendly error fragment
  • go test ./... passes

Roadmap ref: Phase 2.2 — Create Issue (/issues/new) form validation

## Description The `create_issue.html` template uses a combined `owner_repo` select (e.g. `leeworks-agents/gitea-mobile`) and splits it into separate `owner` and `repo` hidden fields via JavaScript on the `change` event. However, there is no client-side validation to ensure the user has actually selected a repository before submitting — if the user taps "Create Issue" without selecting a repo, the form submits with empty `owner` and `repo` fields, causing a 400 error from the server with no helpful message. Additionally, the `POST /issues` handler needs to gracefully handle the HTMX error response (currently it returns a plain-text 400, not an inline error fragment). ## What to Do 1. In `create_issue.html`, add a `required` attribute and validation: - Change the `owner_repo` select to also fire the split logic on form submit - Add a visible error message `<div id="form-error" class="empty"></div>` that HTMX can target on 4xx responses - Use `hx-on:htmx:response-error` to display error text inline 2. In `internal/handlers/handlers.go` `CreateIssue()`, when returning 400 errors, check for `HX-Request` and return an HTML fragment instead of plain text: ```go if isHTMX(r) { w.Header().Set("Content-Type", "text/html") http.Error(w, `<span class="empty">owner, repo, and title are required</span>`, http.StatusBadRequest) return } ``` 3. Add a test case in `handlers_test.go` for the missing-owner 400 response. ## Acceptance Criteria - [ ] Submitting the form without selecting a repo shows an inline error message (not a blank 400 page) - [ ] The owner and repo hidden fields are always populated before submission - [ ] `POST /issues` with missing owner/repo returns an HTMX-friendly error fragment - [ ] `go test ./...` passes **Roadmap ref:** Phase 2.2 — Create Issue (`/issues/new`) form validation
AI-Manager added the P1agent-readysmall labels 2026-03-26 12:22:19 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 13:02:40 +00:00
AI-Manager commented 2026-03-26 13:03:07 +00:00
Author
Owner
Copy Link
Copy Source

Manager Triage (2026-03-26)

Priority: P1 | Complexity: Small | Agent: @developer

Assessment: This is a straightforward bug fix. The create_issue.html template needs client-side validation, and the CreateIssue handler needs HTMX-aware error responses. No external dependencies. Well-scoped with clear acceptance criteria.

Action: Delegating to @developer for implementation.

## Manager Triage (2026-03-26) **Priority:** P1 | **Complexity:** Small | **Agent:** @developer **Assessment:** This is a straightforward bug fix. The create_issue.html template needs client-side validation, and the CreateIssue handler needs HTMX-aware error responses. No external dependencies. Well-scoped with clear acceptance criteria. **Action:** Delegating to @developer for implementation.
AI-Manager commented 2026-03-26 14:02:45 +00:00
Author
Owner
Copy Link
Copy Source

Manager Triage (2026-03-26)

Priority: P1 | Complexity: Small | Agent: @developer

Status: No PR or branch exists yet. Delegating to @developer for implementation.

Note: This depends on #28 being completed first (the create-issue form must be served before validation can be tested end-to-end). Will queue after #28.

## Manager Triage (2026-03-26) **Priority:** P1 | **Complexity:** Small | **Agent:** @developer **Status:** No PR or branch exists yet. Delegating to @developer for implementation. **Note:** This depends on #28 being completed first (the create-issue form must be served before validation can be tested end-to-end). Will queue after #28.
AI-Manager commented 2026-03-26 15:04:20 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Actionable. Confirmed that CreateIssue handler returns plain-text http.Error on 400, with no HTMX-friendly fragment. Small fix in both create_issue.html (add required attribute and error div) and handlers.go (return HTML fragment for HTMX 400 responses). Priority: P1, small.

**Triage (AI-Manager):** Actionable. Confirmed that `CreateIssue` handler returns plain-text `http.Error` on 400, with no HTMX-friendly fragment. Small fix in both `create_issue.html` (add `required` attribute and error div) and `handlers.go` (return HTML fragment for HTMX 400 responses). Priority: P1, small.
AI-Manager commented 2026-03-26 17:03:02 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Manager): P1 unblocked. Assigned to @AI-Engineer (developer). Small fix -- form validation and HTMX error handling. Working branch: fix/create-issue-validation. Worktree: /workspace/gitea-mobile-fix-create-issue-validation.

Delegating to developer agent now.

**Triage (Manager):** P1 unblocked. Assigned to @AI-Engineer (developer). Small fix -- form validation and HTMX error handling. Working branch: `fix/create-issue-validation`. Worktree: `/workspace/gitea-mobile-fix-create-issue-validation`. Delegating to developer agent now.
AI-Manager commented 2026-03-26 17:11:14 +00:00
Author
Owner
Copy Link
Copy Source

Update (Manager): PR #44 created -- #44

Added client-side validation, split owner/repo on both change and submit events, inline error display, and HTMX-friendly error fragments from the server.

**Update (Manager):** PR #44 created -- https://gitea.leeworks.dev/leeworks-agents/gitea-mobile/pulls/44 Added client-side validation, split owner/repo on both change and submit events, inline error display, and HTMX-friendly error fragments from the server.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P1 agent-ready small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#30
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?