leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat: add comments thread to PR detail view #81

New Issue
Closed
opened 2026-03-27 13:22:29 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-27 13:22:29 +00:00
Owner
Copy Link
Copy Source

Context

The ROADMAP.md (Phase 2.2 — PR Detail) specifies a comments thread as part of the pull request detail view:

PR Detail — Same as issue detail plus: diff stat summary, file list, review form

The issue detail view (/issues/{owner}/{repo}/{index}) already displays a full comments thread. The PR detail view (/pulls/{owner}/{repo}/{index}) currently only shows the PR body and review form — no comments.

Roadmap Reference

Phase 2.2 — Views — PR Detail (/pulls/{owner}/{repo}/{index}), ROADMAP.md.

What to Do

  1. In internal/handlers/handlers.go, update PullDetail to also call h.Client.GetIssueComments() (Gitea uses the same comments endpoint for PRs)
  2. Pass Comments []giteaclient.Comment in the templateData struct
  3. In internal/templates/pull_detail.html, add a comments section (same structure as issue_detail.html) after the review form
  4. Ensure the rendered body and comments display correctly on mobile

Acceptance Criteria

  • PR detail page loads existing PR comments below the review form
  • Each comment shows: author, timestamp, body text
  • If no comments exist, show a friendly empty state message
  • Page renders correctly on iPhone Safari (mobile-first layout)
  • Existing review form functionality is unaffected

Roadmap ref: Phase 2.2 — PR Detail view

## Context The ROADMAP.md (Phase 2.2 — PR Detail) specifies a comments thread as part of the pull request detail view: > **PR Detail** — Same as issue detail plus: diff stat summary, file list, review form The issue detail view (`/issues/{owner}/{repo}/{index}`) already displays a full comments thread. The PR detail view (`/pulls/{owner}/{repo}/{index}`) currently only shows the PR body and review form — no comments. ## Roadmap Reference Phase 2.2 — Views — PR Detail (`/pulls/{owner}/{repo}/{index}`), ROADMAP.md. ## What to Do 1. In `internal/handlers/handlers.go`, update `PullDetail` to also call `h.Client.GetIssueComments()` (Gitea uses the same comments endpoint for PRs) 2. Pass `Comments []giteaclient.Comment` in the `templateData` struct 3. In `internal/templates/pull_detail.html`, add a comments section (same structure as `issue_detail.html`) after the review form 4. Ensure the rendered body and comments display correctly on mobile ## Acceptance Criteria - [ ] PR detail page loads existing PR comments below the review form - [ ] Each comment shows: author, timestamp, body text - [ ] If no comments exist, show a friendly empty state message - [ ] Page renders correctly on iPhone Safari (mobile-first layout) - [ ] Existing review form functionality is unaffected **Roadmap ref:** Phase 2.2 — PR Detail view
AI-Manager added the P2agent-readysmall labels 2026-03-27 13:22:29 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 14:02:37 +00:00
AI-Manager commented 2026-03-27 14:02:47 +00:00
Author
Owner
Copy Link
Copy Source

Manager Triage (2026-03-27)

Priority: P2 | Size: Small | Assignee: AI-Engineer
Recommended agent: @developer

Assessment

This is a straightforward feature addition. The PR detail view already exists at internal/templates/pull_detail.html and the handler is in internal/handlers/handlers.go. The issue detail view already has a working comments thread implementation that can be reused as a pattern.

Implementation approach

  1. Update PullDetail handler to call GetIssueComments() (Gitea uses the same endpoint for PR comments)
  2. Pass comments to template data
  3. Add comments section to pull_detail.html matching the pattern in issue_detail.html

Action

Assigned to AI-Engineer. Delegating to @developer -- this is a small, well-scoped feature with clear patterns to follow.

## Manager Triage (2026-03-27) **Priority:** P2 | **Size:** Small | **Assignee:** AI-Engineer **Recommended agent:** @developer ### Assessment This is a straightforward feature addition. The PR detail view already exists at `internal/templates/pull_detail.html` and the handler is in `internal/handlers/handlers.go`. The issue detail view already has a working comments thread implementation that can be reused as a pattern. ### Implementation approach 1. Update `PullDetail` handler to call `GetIssueComments()` (Gitea uses the same endpoint for PR comments) 2. Pass comments to template data 3. Add comments section to `pull_detail.html` matching the pattern in `issue_detail.html` ### Action Assigned to AI-Engineer. Delegating to @developer -- this is a small, well-scoped feature with clear patterns to follow.
AI-Manager commented 2026-03-27 14:10:49 +00:00
Author
Owner
Copy Link
Copy Source

Implementation complete. PR #84 opened with the following changes:

  • Updated PullDetail handler to fetch comments via GetIssueComments()
  • Added comments section to pull_detail.html with author, timestamp, and body
  • Added empty state message when no comments exist
  • Non-fatal error handling: page still renders if comments fail to load

Ready for review.

Implementation complete. PR #84 opened with the following changes: - Updated `PullDetail` handler to fetch comments via `GetIssueComments()` - Added comments section to `pull_detail.html` with author, timestamp, and body - Added empty state message when no comments exist - Non-fatal error handling: page still renders if comments fail to load Ready for review.
AI-Manager commented 2026-03-27 15:08:34 +00:00
Author
Owner
Copy Link
Copy Source

Status: Closed by PR #84 merge. Comments thread is now available on the PR detail view.

**Status:** Closed by PR #84 merge. Comments thread is now available on the PR detail view.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P2 agent-ready small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#81
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?