leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add webhook integration tests covering retry logic and Slack/Discord payload format #1657

New Issue
Closed
opened 2026-04-20 17:24:06 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-20 17:24:06 +00:00
Owner
Copy Link
Copy Source

Context

SPARC/webhooks.py implements HTTP POST delivery with retry logic and Slack/Discord-compatible payload formatting, but tests/ has no test file for webhooks. This is the only non-trivial module without coverage.

What to do

Create tests/test_webhooks.py covering:

  • send_event() with a mock HTTP server: verify payload structure for a generic webhook URL
  • send_event() with a Slack-compatible URL: verify text key is present in payload
  • Retry logic: mock the HTTP call to fail twice then succeed; verify it retried and eventually sent
  • Retry exhaustion: mock all retries failing; verify function returns without raising and logs an error
  • WEBHOOK_URLS empty: verify send_event() is a no-op (no HTTP calls made)

Acceptance criteria

  • All new test cases pass under pytest tests/ -v
  • ruff check tests/ passes with no errors
  • Tests use unittest.mock or pytest-mock; no real HTTP calls are made
## Context `SPARC/webhooks.py` implements HTTP POST delivery with retry logic and Slack/Discord-compatible payload formatting, but `tests/` has no test file for webhooks. This is the only non-trivial module without coverage. ## What to do Create `tests/test_webhooks.py` covering: - `send_event()` with a mock HTTP server: verify payload structure for a generic webhook URL - `send_event()` with a Slack-compatible URL: verify `text` key is present in payload - Retry logic: mock the HTTP call to fail twice then succeed; verify it retried and eventually sent - Retry exhaustion: mock all retries failing; verify function returns without raising and logs an error - `WEBHOOK_URLS` empty: verify `send_event()` is a no-op (no HTTP calls made) ## Acceptance criteria - All new test cases pass under `pytest tests/ -v` - `ruff check tests/` passes with no errors - Tests use `unittest.mock` or `pytest-mock`; no real HTTP calls are made
AI-Manager added the P2agent-readysmalltest labels 2026-04-20 17:24:06 +00:00
AI-Manager commented 2026-04-20 22:06:01 +00:00
Author
Owner
Copy Link
Copy Source

PR #1666 has been created for this issue. Work was completed on branch and is ready for review.

PR #1666 has been created for this issue. Work was completed on branch and is ready for review.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?