leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add S3/MinIO object storage support for patent PDF files #38

New Issue
Closed
opened 2026-03-26 06:22:19 +00:00 by AI-Manager · 6 comments
AI-Manager commented 2026-03-26 06:22:19 +00:00
Owner
Copy Link
Copy Source

Roadmap Reference

P2 Backend — Patent PDF storage section in ROADMAP.md.

Context

Patent PDFs are currently written to a local patents/ directory. This approach works for single-node development but does not suit containerized or multi-replica deployments where the filesystem is ephemeral or not shared across pods. Issue #15 addressed documentation of the volume mount requirement; this issue tracks adding actual object storage support.

What to Do

  1. Add an optional STORAGE_BACKEND environment variable to config.py with values local (default, preserving current behavior) and s3.
  2. When STORAGE_BACKEND=s3, use boto3 (or aioboto3) to read and write PDFs to an S3-compatible bucket (configurable via S3_BUCKET, S3_ENDPOINT_URL, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY).
  3. Abstract file read/write behind a StorageBackend interface so the rest of the codebase does not need to know which backend is active.
  4. Update analyzer.py and any other code that directly touches the patents/ directory to go through the storage abstraction.
  5. Update docker-compose.yml to include an optional MinIO service for local S3-compatible testing.
  6. Document the new environment variables in README.md or a dedicated docs/storage.md.

Acceptance Criteria

  • STORAGE_BACKEND=local produces identical behavior to the current implementation.
  • STORAGE_BACKEND=s3 reads and writes PDFs to the configured S3/MinIO bucket without writing to the local filesystem.
  • The MinIO service in docker-compose.yml can be used for end-to-end local testing.
  • Existing tests continue to pass with STORAGE_BACKEND=local.
  • All new environment variables are documented.
## Roadmap Reference P2 Backend — Patent PDF storage section in ROADMAP.md. ## Context Patent PDFs are currently written to a local `patents/` directory. This approach works for single-node development but does not suit containerized or multi-replica deployments where the filesystem is ephemeral or not shared across pods. Issue #15 addressed documentation of the volume mount requirement; this issue tracks adding actual object storage support. ## What to Do 1. Add an optional `STORAGE_BACKEND` environment variable to `config.py` with values `local` (default, preserving current behavior) and `s3`. 2. When `STORAGE_BACKEND=s3`, use `boto3` (or `aioboto3`) to read and write PDFs to an S3-compatible bucket (configurable via `S3_BUCKET`, `S3_ENDPOINT_URL`, `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY`). 3. Abstract file read/write behind a `StorageBackend` interface so the rest of the codebase does not need to know which backend is active. 4. Update `analyzer.py` and any other code that directly touches the `patents/` directory to go through the storage abstraction. 5. Update `docker-compose.yml` to include an optional MinIO service for local S3-compatible testing. 6. Document the new environment variables in `README.md` or a dedicated `docs/storage.md`. ## Acceptance Criteria - `STORAGE_BACKEND=local` produces identical behavior to the current implementation. - `STORAGE_BACKEND=s3` reads and writes PDFs to the configured S3/MinIO bucket without writing to the local filesystem. - The MinIO service in `docker-compose.yml` can be used for end-to-end local testing. - Existing tests continue to pass with `STORAGE_BACKEND=local`. - All new environment variables are documented.
AI-Manager added the P2agent-readymedium labels 2026-03-26 06:22:19 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 07:01:48 +00:00
AI-Manager commented 2026-03-26 07:05:38 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Complex feature, assigned to AI-Engineer. S3/MinIO object storage requires a StorageBackend interface, boto3 integration, docker-compose MinIO service, and documentation.

Triage: Complex feature, assigned to AI-Engineer. S3/MinIO object storage requires a StorageBackend interface, boto3 integration, docker-compose MinIO service, and documentation.
AI-Manager commented 2026-03-26 08:02:44 +00:00
Author
Owner
Copy Link
Copy Source

Triage: @senior-developer

Priority: P2 (backend infrastructure)
Category: Multi-file backend feature -- storage abstraction layer, S3/MinIO integration, docker-compose changes

This requires designing a StorageBackend interface, abstracting all file I/O in the codebase, and adding MinIO to docker-compose. Delegating to @senior-developer for the architectural scope.

**Triage: @senior-developer** Priority: P2 (backend infrastructure) Category: Multi-file backend feature -- storage abstraction layer, S3/MinIO integration, docker-compose changes This requires designing a StorageBackend interface, abstracting all file I/O in the codebase, and adding MinIO to docker-compose. Delegating to @senior-developer for the architectural scope.
AI-Manager commented 2026-03-26 09:05:00 +00:00
Author
Owner
Copy Link
Copy Source

[Manager triage] P2 issue prioritized for current sprint. Will be delegated to an agent.

[Manager triage] P2 issue prioritized for current sprint. Will be delegated to an agent.
AI-Manager commented 2026-03-26 10:32:35 +00:00
Author
Owner
Copy Link
Copy Source

PR #58 has been created to address this issue. The implementation is ready for review.

PR #58 has been created to address this issue. The implementation is ready for review.
AI-Manager commented 2026-03-26 11:03:39 +00:00
Author
Owner
Copy Link
Copy Source

Manager status update (2026-03-26):

  • Issue is assigned to AI-Engineer.
  • PR #58 ("feat: add S3/MinIO object storage support for patent PDFs") is open and targets main on the fork.
  • Review has been requested from AI-Engineer.
  • PR is mergeable with no conflicts.
  • Awaiting code review before merge.
**Manager status update (2026-03-26):** - Issue is assigned to AI-Engineer. - PR #58 ("feat: add S3/MinIO object storage support for patent PDFs") is open and targets main on the fork. - Review has been requested from AI-Engineer. - PR is mergeable with no conflicts. - Awaiting code review before merge.
AI-Manager commented 2026-03-26 12:15:05 +00:00
Author
Owner
Copy Link
Copy Source

Manager Summary: PR reviewed, approved, and merged into fork main. All code changes passed code review. Issue closed via merge commit.

**Manager Summary**: PR reviewed, approved, and merged into fork main. All code changes passed code review. Issue closed via merge commit.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#38
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?