0xWheatyz/SPARC
1
0
Fork 2
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix scheduler tests to use get_db_client after scheduler refactor

Browse Source 
The scheduler was refactored (PR #1665) to use the pooled
get_db_client() from SPARC.auth instead of creating its own
DatabaseClient. Update test mocks accordingly and remove the
db.close() assertion since the pooled client is no longer closed
by the scheduler.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
agent-company
2026-04-20 23:05:42 +00:00
parent e610dea9a9
commit 6165d66760
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_tracked_companies.py
+6 -7
View File
@@ -272,7 +272,7 @@ class TestSchedulerIntegration:
mock_db = MagicMock() mock_db = MagicMock()
mock_db.list_tracked_companies.return_value = [] mock_db.list_tracked_companies.return_value = []
with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \
patch("SPARC.scheduler.CompanyAnalyzer") as mock_analyzer_cls: patch("SPARC.scheduler.CompanyAnalyzer") as mock_analyzer_cls:
from SPARC.scheduler import run_scheduled_analysis from SPARC.scheduler import run_scheduled_analysis
run_scheduled_analysis() run_scheduled_analysis()
@@ -292,7 +292,7 @@ class TestSchedulerIntegration:
mock_analyzer = MagicMock() mock_analyzer = MagicMock()
mock_analyzer._analyze_company_safe.side_effect = [mock_result_nvidia, mock_result_amd] mock_analyzer._analyze_company_safe.side_effect = [mock_result_nvidia, mock_result_amd]
with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \
patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer):
from SPARC.scheduler import run_scheduled_analysis from SPARC.scheduler import run_scheduled_analysis
run_scheduled_analysis() run_scheduled_analysis()
@@ -312,7 +312,7 @@ class TestSchedulerIntegration:
mock_analyzer = MagicMock() mock_analyzer = MagicMock()
mock_analyzer._analyze_company_safe.return_value = mock_result mock_analyzer._analyze_company_safe.return_value = mock_result
with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \
patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer):
from SPARC.scheduler import run_scheduled_analysis from SPARC.scheduler import run_scheduled_analysis
run_scheduled_analysis() run_scheduled_analysis()
@@ -335,7 +335,7 @@ class TestSchedulerIntegration:
mock_analyzer = MagicMock() mock_analyzer = MagicMock()
mock_analyzer._analyze_company_safe.return_value = mock_result mock_analyzer._analyze_company_safe.return_value = mock_result
with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \
patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer):
from SPARC.scheduler import run_scheduled_analysis from SPARC.scheduler import run_scheduled_analysis
run_scheduled_analysis() run_scheduled_analysis()
@@ -355,7 +355,7 @@ class TestSchedulerIntegration:
mock_analyzer = MagicMock() mock_analyzer = MagicMock()
mock_analyzer._analyze_company_safe.side_effect = [mock_fail_result, mock_ok_result] mock_analyzer._analyze_company_safe.side_effect = [mock_fail_result, mock_ok_result]
with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \
patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer):
from SPARC.scheduler import run_scheduled_analysis from SPARC.scheduler import run_scheduled_analysis
run_scheduled_analysis() run_scheduled_analysis()
@@ -378,11 +378,10 @@ class TestSchedulerIntegration:
mock_ok_result, mock_ok_result,
] ]
with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \
patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer):
from SPARC.scheduler import run_scheduled_analysis from SPARC.scheduler import run_scheduled_analysis
run_scheduled_analysis() run_scheduled_analysis()
# OKCo should still be processed # OKCo should still be processed
mock_db.update_tracked_company.assert_called_once_with("OKCo", 22) mock_db.update_tracked_company.assert_called_once_with("OKCo", 22)
mock_db.close.assert_called_once()