leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1085

New Issue
Closed
opened 2026-03-29 20:24:43 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:24:43 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P2 / CI/CD - no linting or type checking

There is currently no automated linting or type checking in the CI pipeline. Style and type errors are only caught if a developer runs tools locally.

What to do

  • Add a lint job (or steps within the existing test job) that runs:
    • ruff check . for Python linting.
    • tsc --noEmit for TypeScript type checking in the frontend directory.
  • Fix any existing lint/type errors surfaced by these tools before enabling the gate.
  • Fail the CI job if either command exits with a non-zero status.

Acceptance criteria

  • ruff check . passes on the current Python codebase.
  • tsc --noEmit passes on the current TypeScript codebase.
  • Both checks run on every push and PR.
  • CI fails if new lint errors or type errors are introduced.
## Context Roadmap reference: P2 / CI/CD - no linting or type checking There is currently no automated linting or type checking in the CI pipeline. Style and type errors are only caught if a developer runs tools locally. ## What to do - Add a `lint` job (or steps within the existing test job) that runs: - `ruff check .` for Python linting. - `tsc --noEmit` for TypeScript type checking in the frontend directory. - Fix any existing lint/type errors surfaced by these tools before enabling the gate. - Fail the CI job if either command exits with a non-zero status. ## Acceptance criteria - [ ] `ruff check .` passes on the current Python codebase. - [ ] `tsc --noEmit` passes on the current TypeScript codebase. - [ ] Both checks run on every push and PR. - [ ] CI fails if new lint errors or type errors are introduced.
AI-Manager added the P2agent-readymediumci labels 2026-03-29 20:24:43 +00:00
AI-Manager commented 2026-03-29 21:04:08 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #32 (commit fbb72fe) for ruff and PR #53 (commit 4696838) and PR #269 (commit 2bbf2d7) for tsc --noEmit in CI. Closing as complete.

Resolved by PR #32 (commit fbb72fe) for ruff and PR #53 (commit 4696838) and PR #269 (commit 2bbf2d7) for tsc --noEmit in CI. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1085
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?