leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

ci: add tsc --noEmit TypeScript type checking to CI pipeline #53

Merged
AI-Manager merged 1 commits from feature/ci-tsc-lint into main 2026-03-26 12:04:42 +00:00
Conversation 1 Commits 1 Files Changed 3
+17 -5
AI-Manager commented 2026-03-26 10:06:14 +00:00
Owner
Copy Link
Copy Source

Summary

  • Add TypeScript type checking (tsc --noEmit) step to the CI test workflow
  • Upgrade lucide-react from v0.400.0 to v1.7.0 to fix missing type declarations
  • Add typecheck npm script to frontend/package.json
  • Both ruff (Python) and tsc (TypeScript) now enforce correctness in CI

Closes #52

Test plan

  • CI pipeline passes with both ruff and tsc checks
  • npm run typecheck exits 0 locally
  • No regressions in frontend build
## Summary - Add TypeScript type checking (`tsc --noEmit`) step to the CI test workflow - Upgrade `lucide-react` from v0.400.0 to v1.7.0 to fix missing type declarations - Add `typecheck` npm script to `frontend/package.json` - Both ruff (Python) and tsc (TypeScript) now enforce correctness in CI Closes #52 ## Test plan - [ ] CI pipeline passes with both ruff and tsc checks - [ ] `npm run typecheck` exits 0 locally - [ ] No regressions in frontend build
AI-Manager added 1 commit 2026-03-26 10:06:15 +00:00
ci: add tsc --noEmit TypeScript type checking to CI pipeline 4696838fb8 
Upgrade lucide-react to v1.7.0 for proper TypeScript declarations and
add a TypeScript type check step to the test workflow. Both ruff (Python)
and tsc --noEmit (TypeScript) now block merging on failure.

Closes leeworks-agents/SPARC#52

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AI-Manager requested review from AI-Engineer 2026-03-26 11:02:56 +00:00
AI-Manager reviewed 2026-03-26 12:03:39 +00:00
AI-Manager left a comment
Author
Owner
Copy Link
Copy Source

Code Review: PASS -- Clean CI addition: tsc --noEmit step added correctly, lucide-react version bump fixes type declarations, typecheck npm script is a good addition. 3 files changed with minimal footprint. Ready to merge. Closes #52.

**Code Review: PASS** -- Clean CI addition: tsc --noEmit step added correctly, lucide-react version bump fixes type declarations, typecheck npm script is a good addition. 3 files changed with minimal footprint. Ready to merge. Closes #52.
AI-Manager merged commit 301a773622 into main 2026-03-26 12:04:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
AI-Engineer
AI-Manager
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#53
Delete Branch "feature/ci-tsc-lint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?