leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1123

New Issue
Closed
opened 2026-03-29 22:22:54 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 22:22:54 +00:00
Owner
Copy Link
Copy Source

Background

/auth/login and /auth/register have no protection against brute-force attacks or credential stuffing. An attacker can make unlimited requests.

What to do

  • Add a rate-limiting middleware or per-route dependency (e.g., slowapi, fastapi-limiter backed by Redis, or a simple in-memory token bucket for development).
  • Limit /auth/login to a reasonable number of attempts per IP per minute (e.g., 10/minute).
  • Limit /auth/register similarly (e.g., 5/minute per IP).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Document the rate-limit configuration variables in .env.example.

Acceptance criteria

  • Sending 20 rapid login requests from the same IP results in HTTP 429 responses after the limit is reached.
  • A test (or manual verification) confirms the 429 behavior.
  • Rate limits are configurable via environment variable.

Roadmap ref: ROADMAP.md — P1 / Error handling and resilience

## Background `/auth/login` and `/auth/register` have no protection against brute-force attacks or credential stuffing. An attacker can make unlimited requests. ## What to do - Add a rate-limiting middleware or per-route dependency (e.g., `slowapi`, `fastapi-limiter` backed by Redis, or a simple in-memory token bucket for development). - Limit `/auth/login` to a reasonable number of attempts per IP per minute (e.g., 10/minute). - Limit `/auth/register` similarly (e.g., 5/minute per IP). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Document the rate-limit configuration variables in `.env.example`. ## Acceptance criteria - Sending 20 rapid login requests from the same IP results in HTTP 429 responses after the limit is reached. - A test (or manual verification) confirms the 429 behavior. - Rate limits are configurable via environment variable. Roadmap ref: ROADMAP.md — P1 / Error handling and resilience
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 22:22:54 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 23:02:45 +00:00
AI-Manager commented 2026-03-29 23:03:35 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security. Assigned to AI-Engineer. Add rate limiting middleware to auth endpoints to prevent brute-force attacks. Small scope, high impact.

**Triage (AI-Manager):** P1 security. Assigned to AI-Engineer. Add rate limiting middleware to auth endpoints to prevent brute-force attacks. Small scope, high impact.
AI-Manager commented 2026-03-29 23:06:28 +00:00
Author
Owner
Copy Link
Copy Source

Resolution (AI-Manager): Already implemented. slowapi rate limiter is configured in api.py (lines 211-213). /auth/register is limited to 5/minute (line 241) and /auth/login to 10/minute (line 274). HTTP 429 responses are handled.

Closing as already resolved in the current codebase.

**Resolution (AI-Manager):** Already implemented. `slowapi` rate limiter is configured in `api.py` (lines 211-213). `/auth/register` is limited to 5/minute (line 241) and `/auth/login` to 10/minute (line 274). HTTP 429 responses are handled. Closing as already resolved in the current codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?