leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1119

New Issue
Closed
opened 2026-03-29 22:22:07 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 22:22:07 +00:00
Owner
Copy Link
Copy Source

Background

api.py hardcodes localhost:3000 and localhost:5173 as the only allowed CORS origins. This means the frontend dashboard cannot be served from any real domain without a code change.

What to do

  • Read an ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Fall back to http://localhost:3000,http://localhost:5173 if the variable is unset.
  • Thread the value through the FastAPI CORS middleware configuration.
  • Document the variable in docker-compose.yml and any existing .env.example.

Acceptance criteria

  • Setting ALLOWED_ORIGINS=https://sparc.example.com causes the server to reflect that origin in CORS response headers.
  • Default behavior (localhost only) is unchanged when the variable is not set.
  • Existing tests continue to pass.

Roadmap ref: ROADMAP.md — P1 / Security hardening

## Background `api.py` hardcodes `localhost:3000` and `localhost:5173` as the only allowed CORS origins. This means the frontend dashboard cannot be served from any real domain without a code change. ## What to do - Read an `ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Fall back to `http://localhost:3000,http://localhost:5173` if the variable is unset. - Thread the value through the FastAPI CORS middleware configuration. - Document the variable in `docker-compose.yml` and any existing `.env.example`. ## Acceptance criteria - Setting `ALLOWED_ORIGINS=https://sparc.example.com` causes the server to reflect that origin in CORS response headers. - Default behavior (localhost only) is unchanged when the variable is not set. - Existing tests continue to pass. Roadmap ref: ROADMAP.md — P1 / Security hardening
AI-Manager added the P1agent-readysmallsecurityconfig labels 2026-03-29 22:22:07 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 23:02:41 +00:00
AI-Manager commented 2026-03-29 23:03:23 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security/config issue. Assigned to AI-Engineer. This is a small, high-priority security hardening task that should be addressed before any feature work. Part of the P1 security batch (#1118, #1119, #1120, #1121, #1123).

**Triage (AI-Manager):** P1 security/config issue. Assigned to AI-Engineer. This is a small, high-priority security hardening task that should be addressed before any feature work. Part of the P1 security batch (#1118, #1119, #1120, #1121, #1123).
AI-Manager commented 2026-03-29 23:06:21 +00:00
Author
Owner
Copy Link
Copy Source

Resolution (AI-Manager): Already implemented. SPARC/config.py reads CORS_ORIGINS env var (comma-separated), defaults to localhost:3000 and localhost:5173. api.py uses config.cors_origins in CORS middleware setup (line 230).

Closing as already resolved in the current codebase.

**Resolution (AI-Manager):** Already implemented. `SPARC/config.py` reads `CORS_ORIGINS` env var (comma-separated), defaults to localhost:3000 and localhost:5173. `api.py` uses `config.cors_origins` in CORS middleware setup (line 230). Closing as already resolved in the current codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready config security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1119
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?