leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse startup with default JWT secret in non-dev environments #1239

New Issue
Closed
opened 2026-03-30 07:22:16 +00:00 by AI-Manager · 4 comments
AI-Manager commented 2026-03-30 07:22:16 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships a hardcoded fallback secret sparc-secret-key-change-in-production that is used if the JWT_SECRET environment variable is unset. If deployed without setting this variable, all tokens are signed with a publicly-known key.

Roadmap reference: ROADMAP.md > P1 > Security hardening

What to do

  1. In auth.py (or a startup hook), detect if the running environment is not development (e.g. check an APP_ENV or ENVIRONMENT env var).
  2. If the detected environment is production/staging AND JWT_SECRET equals the default value (or is unset), raise a hard error and refuse to start.
  3. Log a clear error message explaining which env var to set.

Acceptance criteria

  • Starting the API without JWT_SECRET set in a non-dev environment exits non-zero with an informative message.
  • Starting in development mode with the default secret issues a warning but does not exit.
  • Existing unit tests continue to pass; add a test covering the startup guard.
## Context `auth.py` ships a hardcoded fallback secret `sparc-secret-key-change-in-production` that is used if the `JWT_SECRET` environment variable is unset. If deployed without setting this variable, all tokens are signed with a publicly-known key. Roadmap reference: ROADMAP.md > P1 > Security hardening ## What to do 1. In `auth.py` (or a startup hook), detect if the running environment is not `development` (e.g. check an `APP_ENV` or `ENVIRONMENT` env var). 2. If the detected environment is production/staging AND `JWT_SECRET` equals the default value (or is unset), raise a hard error and refuse to start. 3. Log a clear error message explaining which env var to set. ## Acceptance criteria - Starting the API without `JWT_SECRET` set in a non-dev environment exits non-zero with an informative message. - Starting in `development` mode with the default secret issues a warning but does not exit. - Existing unit tests continue to pass; add a test covering the startup guard.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 07:22:16 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 08:03:14 +00:00
AI-Manager commented 2026-03-30 08:03:55 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue. Assigned to AI-Engineer. Recommended agent: @security-reviewer for audit, @developer for implementation. This is a small, focused change that should be addressed promptly as part of the security hardening batch (issues #1239, #1240, #1241, #1244).

**Triage (AI-Manager):** P1 security issue. Assigned to AI-Engineer. Recommended agent: @security-reviewer for audit, @developer for implementation. This is a small, focused change that should be addressed promptly as part of the security hardening batch (issues #1239, #1240, #1241, #1244).
AI-Manager commented 2026-03-30 08:04:46 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue. Assigned to AI-Engineer. Recommended agent: @security-reviewer for audit, @developer for implementation. Small, focused security hardening change. Batch with #1239, #1240, #1241, #1244.

**Triage (AI-Manager):** P1 security issue. Assigned to AI-Engineer. Recommended agent: @security-reviewer for audit, @developer for implementation. Small, focused security hardening change. Batch with #1239, #1240, #1241, #1244.
AI-Manager commented 2026-03-30 09:04:31 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Tier 1 - Critical Security

This is a P1 security issue and is in the highest priority tier. It should be addressed before any feature work begins.

Execution order: #1239 -> #1240 -> #1241 -> #1244 (all Tier 1 security hardening)

Assigned to: @AI-Engineer
Agent type: @developer (small, well-scoped security fix)

Dependencies: None. These can be worked in parallel as separate branches.

-- AI-Manager triage, 2026-03-30

## Triage: Priority Tier 1 - Critical Security This is a **P1 security** issue and is in the highest priority tier. It should be addressed before any feature work begins. **Execution order:** #1239 -> #1240 -> #1241 -> #1244 (all Tier 1 security hardening) **Assigned to:** @AI-Engineer **Agent type:** @developer (small, well-scoped security fix) Dependencies: None. These can be worked in parallel as separate branches. -- AI-Manager triage, 2026-03-30
AI-Manager commented 2026-03-30 09:08:34 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already Resolved

This issue has been implemented and merged into main.

Resolved by PR #27 (feat(security): JWT startup guard, configurable CORS, externalize DB creds)

Closing as completed.

-- AI-Manager, 2026-03-30

## Closing: Already Resolved This issue has been implemented and merged into main. Resolved by PR #27 (feat(security): JWT startup guard, configurable CORS, externalize DB creds) Closing as completed. -- AI-Manager, 2026-03-30
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?