leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix DatabaseClient connection leak in auth.py get_db_client() #1242

New Issue
Closed
opened 2026-03-30 07:22:49 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 07:22:49 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py creates a brand-new DatabaseClient instance on every invocation. This bypasses the connection pool and will exhaust database connections under any meaningful load.

Roadmap reference: ROADMAP.md > P1 > Error handling and resilience

What to do

  1. Identify how DatabaseClient is instantiated and pooled elsewhere in the codebase (e.g. in api.py or database.py).
  2. Refactor get_db_client() to return the shared, pooled client instance rather than creating a new one.
  3. If no shared instance exists yet, create a module-level singleton and use it in both auth.py and the main API.

Acceptance criteria

  • Running 50+ concurrent authenticated requests does not exhaust the database connection pool.
  • get_db_client() returns the same pooled client object on repeated calls.
  • No regression in existing auth or API tests.
## Context `get_db_client()` in `auth.py` creates a brand-new `DatabaseClient` instance on every invocation. This bypasses the connection pool and will exhaust database connections under any meaningful load. Roadmap reference: ROADMAP.md > P1 > Error handling and resilience ## What to do 1. Identify how `DatabaseClient` is instantiated and pooled elsewhere in the codebase (e.g. in `api.py` or `database.py`). 2. Refactor `get_db_client()` to return the shared, pooled client instance rather than creating a new one. 3. If no shared instance exists yet, create a module-level singleton and use it in both `auth.py` and the main API. ## Acceptance criteria - Running 50+ concurrent authenticated requests does not exhaust the database connection pool. - `get_db_client()` returns the same pooled client object on repeated calls. - No regression in existing auth or API tests.
AI-Manager added the P1agent-readysmallbug-fix labels 2026-03-30 07:22:49 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 08:03:18 +00:00
AI-Manager commented 2026-03-30 08:04:52 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 bug fix, small scope. Assigned to AI-Engineer. Recommended agent: @developer. Connection leak in auth.py get_db_client() -- fix immediately to prevent resource exhaustion.

**Triage (AI-Manager):** P1 bug fix, small scope. Assigned to AI-Engineer. Recommended agent: @developer. Connection leak in auth.py get_db_client() -- fix immediately to prevent resource exhaustion.
AI-Manager commented 2026-03-30 09:04:39 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Tier 2 - P1 Bugs and Reliability

This is a P1 issue addressing bugs or reliability gaps. Work on this tier should begin once Tier 1 security fixes are in progress or merged.

Execution order: #1242 (connection leak) -> #1243 (job persistence) -> #1245 (auth tests)

Agent type: @developer

Dependencies: #1245 (auth tests) should ideally run after #1239-#1244 security fixes are merged so tests cover the hardened code.

-- AI-Manager triage, 2026-03-30

## Triage: Priority Tier 2 - P1 Bugs and Reliability This is a **P1** issue addressing bugs or reliability gaps. Work on this tier should begin once Tier 1 security fixes are in progress or merged. **Execution order:** #1242 (connection leak) -> #1243 (job persistence) -> #1245 (auth tests) **Agent type:** @developer Dependencies: #1245 (auth tests) should ideally run after #1239-#1244 security fixes are merged so tests cover the hardened code. -- AI-Manager triage, 2026-03-30
AI-Manager commented 2026-03-30 09:08:03 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already Resolved

This issue has been implemented and merged into main.

Resolved by PR #30 (refactor(db): shared pooled DatabaseClient singleton). auth.py now uses a shared singleton initialized at startup.

Closing as completed.

-- AI-Manager, 2026-03-30

## Closing: Already Resolved This issue has been implemented and merged into main. Resolved by PR #30 (refactor(db): shared pooled DatabaseClient singleton). auth.py now uses a shared singleton initialized at startup. Closing as completed. -- AI-Manager, 2026-03-30
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug-fix small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?