leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff linting and tsc type checking to CI #130

New Issue
Closed
opened 2026-03-26 16:23:56 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 16:23:56 +00:00
Owner
Copy Link
Copy Source

Context

Neither Python linting (ruff) nor TypeScript type checking (tsc --noEmit) is run in CI. Style and type errors can be merged undetected.

Work

  • Add a lint job to build.yaml that runs ruff check on the backend Python source.
  • Add a type-check job (or step) that runs tsc --noEmit on the frontend TypeScript source.
  • Configure ruff via pyproject.toml or ruff.toml with sensible defaults.
  • Ensure both jobs must pass before the Docker build job proceeds.

Acceptance Criteria

  • ruff check runs on every push/PR and reports any lint errors.
  • tsc --noEmit runs on every push/PR and reports any type errors.
  • Both checks pass on a clean main branch.
  • A PR introducing a ruff or tsc error fails CI before building the image.

References

Roadmap: P2 -- CI/CD -- No linting or type checking.

## Context Neither Python linting (ruff) nor TypeScript type checking (tsc --noEmit) is run in CI. Style and type errors can be merged undetected. ## Work - Add a lint job to build.yaml that runs ruff check on the backend Python source. - Add a type-check job (or step) that runs tsc --noEmit on the frontend TypeScript source. - Configure ruff via pyproject.toml or ruff.toml with sensible defaults. - Ensure both jobs must pass before the Docker build job proceeds. ## Acceptance Criteria - ruff check runs on every push/PR and reports any lint errors. - tsc --noEmit runs on every push/PR and reports any type errors. - Both checks pass on a clean main branch. - A PR introducing a ruff or tsc error fails CI before building the image. ## References Roadmap: P2 -- CI/CD -- No linting or type checking.
AI-Manager added the P2agent-readysmall labels 2026-03-26 16:23:56 +00:00
AI-Manager commented 2026-03-26 17:03:26 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved. The CI workflow (.gitea/workflows/test.yml) includes both ruff linting (ruff check SPARC/ tests/) and TypeScript type checking (npx tsc --noEmit).

Resolved by PR #32 and PR #53. Closing.

This issue has already been resolved. The CI workflow (`.gitea/workflows/test.yml`) includes both ruff linting (`ruff check SPARC/ tests/`) and TypeScript type checking (`npx tsc --noEmit`). Resolved by PR #32 and PR #53. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?