leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1390

New Issue
Closed
opened 2026-03-30 17:25:37 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:25:37 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P2 CI/CD -- No linting or type checking

Neither the Python backend nor the TypeScript frontend is linted or type-checked in CI. Style and type errors accumulate silently.

Task

  1. Add ruff to the Python dev dependencies and run ruff check . in the CI test/lint job.
  2. Add tsc --noEmit to the frontend build step in CI (requires a tsconfig.json if not present).
  3. Fix any ruff or tsc errors that exist on the current main branch before enabling the check.
  4. Add a ruff config section to pyproject.toml (or ruff.toml) with sensible defaults.

Acceptance Criteria

  • ruff check . runs in CI and fails the workflow on Python lint errors.
  • tsc --noEmit runs in CI and fails on TypeScript type errors.
  • The current main branch passes both checks.
  • ruff and tsc configurations are committed.

Reference

See ROADMAP.md section P2 CI/CD.

## Background Roadmap item: **P2 CI/CD -- No linting or type checking** Neither the Python backend nor the TypeScript frontend is linted or type-checked in CI. Style and type errors accumulate silently. ## Task 1. Add ruff to the Python dev dependencies and run `ruff check .` in the CI test/lint job. 2. Add `tsc --noEmit` to the frontend build step in CI (requires a tsconfig.json if not present). 3. Fix any ruff or tsc errors that exist on the current main branch before enabling the check. 4. Add a ruff config section to pyproject.toml (or ruff.toml) with sensible defaults. ## Acceptance Criteria - [ ] `ruff check .` runs in CI and fails the workflow on Python lint errors. - [ ] `tsc --noEmit` runs in CI and fails on TypeScript type errors. - [ ] The current main branch passes both checks. - [ ] ruff and tsc configurations are committed. ## Reference See ROADMAP.md section P2 CI/CD.
AI-Manager added the P2agent-readysmallci labels 2026-03-30 17:25:37 +00:00
AI-Manager commented 2026-03-30 18:05:10 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PRs #32, #269, and #53 (merged). Both ruff (Python linting) and tsc --noEmit (TypeScript type checking) are included in the CI pipeline.

Resolved by PRs #32, #269, and #53 (merged). Both ruff (Python linting) and `tsc --noEmit` (TypeScript type checking) are included in the CI pipeline.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1390
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?