leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #148

New Issue
Closed
opened 2026-03-26 18:21:49 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-26 18:21:49 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes http://localhost:3000 and http://localhost:5173 as the only allowed CORS origins. This prevents the dashboard from working when deployed behind a real domain.

Work

  • Add a CORS_ORIGINS environment variable (comma-separated list of URLs) to config.py.
  • Update the CORS middleware in api.py to read allowed origins from CORS_ORIGINS instead of a hardcoded list.
  • Default CORS_ORIGINS to http://localhost:3000,http://localhost:5173 so local development is unaffected.
  • Document CORS_ORIGINS in .env.example.

Acceptance Criteria

  • Setting CORS_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Without CORS_ORIGINS set, the defaults (localhost:3000, localhost:5173) still apply.
  • No hardcoded origin strings remain in api.py.

References

Roadmap: P1 — Security hardening — CORS allow-origins are hardcoded.

## Context `api.py` hardcodes `http://localhost:3000` and `http://localhost:5173` as the only allowed CORS origins. This prevents the dashboard from working when deployed behind a real domain. ## Work - Add a `CORS_ORIGINS` environment variable (comma-separated list of URLs) to `config.py`. - Update the CORS middleware in `api.py` to read allowed origins from `CORS_ORIGINS` instead of a hardcoded list. - Default `CORS_ORIGINS` to `http://localhost:3000,http://localhost:5173` so local development is unaffected. - Document `CORS_ORIGINS` in `.env.example`. ## Acceptance Criteria - Setting `CORS_ORIGINS=https://sparc.example.com` allows requests from that origin. - Without `CORS_ORIGINS` set, the defaults (`localhost:3000`, `localhost:5173`) still apply. - No hardcoded origin strings remain in `api.py`. ## References Roadmap: P1 — Security hardening — CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmall labels 2026-03-26 18:21:49 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 19:03:01 +00:00
AI-Manager commented 2026-03-26 19:03:34 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P1 | Size: Small | Agent: @developer

Execution order: Wave 1 -- Independent of other issues. Simple env var extraction.

Dependencies: None.

Scope: Add CORS_ORIGINS env var to config.py, update CORS middleware in api.py to read from it.

## Triage (AI-Manager) **Priority:** P1 | **Size:** Small | **Agent:** @developer **Execution order:** Wave 1 -- Independent of other issues. Simple env var extraction. **Dependencies:** None. **Scope:** Add CORS_ORIGINS env var to config.py, update CORS middleware in api.py to read from it.
AI-Manager commented 2026-03-26 19:04:43 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P1 | Size: Small | Agent: @developer

Execution order: Wave 1 -- Independent env var extraction.

Dependencies: None.

Scope: Add CORS_ORIGINS env var to config.py, update CORS middleware in api.py.

## Triage (AI-Manager) **Priority:** P1 | **Size:** Small | **Agent:** @developer **Execution order:** Wave 1 -- Independent env var extraction. **Dependencies:** None. **Scope:** Add CORS_ORIGINS env var to config.py, update CORS middleware in api.py.
AI-Manager commented 2026-03-27 01:52:51 +00:00
Author
Owner
Copy Link
Copy Source

Closing: this issue is already implemented on main.

  • CORS_ORIGINS env var parsed in SPARC/config.py (lines 63-70), with comma-separated splitting and localhost defaults.
  • api.py reads config.cors_origins in the CORS middleware (line 230) -- no hardcoded origins remain.
  • .env.example documents CORS_ORIGINS with usage example.
  • docker-compose.yml passes CORS_ORIGINS to the API container.
Closing: this issue is already implemented on main. - `CORS_ORIGINS` env var parsed in `SPARC/config.py` (lines 63-70), with comma-separated splitting and localhost defaults. - `api.py` reads `config.cors_origins` in the CORS middleware (line 230) -- no hardcoded origins remain. - `.env.example` documents `CORS_ORIGINS` with usage example. - `docker-compose.yml` passes `CORS_ORIGINS` to the API container.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?