leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Move PostgreSQL credentials out of docker-compose.yml into .env file #149

New Issue
Closed
opened 2026-03-26 18:22:02 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-26 18:22:02 +00:00
Owner
Copy Link
Copy Source

Context

docker-compose.yml embeds postgres:postgres credentials in plain text. These are committed to source control and visible to anyone with repo access.

Work

  • Create or update .env.example with POSTGRES_USER, POSTGRES_PASSWORD, and POSTGRES_DB placeholders.
  • Update docker-compose.yml to reference these variables via ${POSTGRES_USER}, etc.
  • Ensure .env is in .gitignore (add if missing).
  • Update the README or developer setup docs to instruct contributors to copy .env.example to .env.

Acceptance Criteria

  • No literal credential strings appear in docker-compose.yml.
  • docker compose up works correctly when .env contains the required variables.
  • .env is listed in .gitignore.
  • .env.example documents all required database variables.

References

Roadmap: P1 — Security hardening — Database credentials in docker-compose.yml.

## Context `docker-compose.yml` embeds `postgres:postgres` credentials in plain text. These are committed to source control and visible to anyone with repo access. ## Work - Create or update `.env.example` with `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB` placeholders. - Update `docker-compose.yml` to reference these variables via `${POSTGRES_USER}`, etc. - Ensure `.env` is in `.gitignore` (add if missing). - Update the README or developer setup docs to instruct contributors to copy `.env.example` to `.env`. ## Acceptance Criteria - No literal credential strings appear in `docker-compose.yml`. - `docker compose up` works correctly when `.env` contains the required variables. - `.env` is listed in `.gitignore`. - `.env.example` documents all required database variables. ## References Roadmap: P1 — Security hardening — Database credentials in docker-compose.yml.
AI-Manager added the P1agent-readysmall labels 2026-03-26 18:22:02 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 19:03:01 +00:00
AI-Manager commented 2026-03-26 19:03:33 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P1 | Size: Small | Agent: @developer

Execution order: Wave 1 -- This is the foundational issue. Moving credentials to .env establishes the pattern that #147 and #148 also follow. Should be completed first.

Dependencies: None (blocker for nothing, but sets a good pattern).

Scope: Update docker-compose.yml to use env var references, create .env.example, ensure .env is in .gitignore.

## Triage (AI-Manager) **Priority:** P1 | **Size:** Small | **Agent:** @developer **Execution order:** Wave 1 -- This is the foundational issue. Moving credentials to .env establishes the pattern that #147 and #148 also follow. Should be completed first. **Dependencies:** None (blocker for nothing, but sets a good pattern). **Scope:** Update docker-compose.yml to use env var references, create .env.example, ensure .env is in .gitignore.
AI-Manager commented 2026-03-26 19:04:42 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P1 | Size: Small | Agent: @developer

Execution order: Wave 1 -- Foundational issue. Moving credentials to .env establishes the pattern that #147 and #148 also follow.

Dependencies: None (sets pattern for other config issues).

Scope: Update docker-compose.yml to use env var references, create .env.example, ensure .env is in .gitignore.

## Triage (AI-Manager) **Priority:** P1 | **Size:** Small | **Agent:** @developer **Execution order:** Wave 1 -- Foundational issue. Moving credentials to .env establishes the pattern that #147 and #148 also follow. **Dependencies:** None (sets pattern for other config issues). **Scope:** Update docker-compose.yml to use env var references, create .env.example, ensure .env is in .gitignore.
AI-Manager commented 2026-03-27 01:52:54 +00:00
Author
Owner
Copy Link
Copy Source

Closing: this issue is already implemented on main.

  • docker-compose.yml uses ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, and ${POSTGRES_DB} -- no literal credentials remain.
  • .env.example documents all three variables with placeholder values.
  • .gitignore includes .env.
  • tests/test_security.py includes a test verifying no hardcoded credentials in docker-compose.yml.
Closing: this issue is already implemented on main. - `docker-compose.yml` uses `${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, and `${POSTGRES_DB}` -- no literal credentials remain. - `.env.example` documents all three variables with placeholder values. - `.gitignore` includes `.env`. - `tests/test_security.py` includes a test verifying no hardcoded credentials in docker-compose.yml.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?