leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to reject default JWT secret in non-dev environments #285

New Issue
Closed
opened 2026-03-27 11:21:54 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 11:21:54 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships with a fallback secret sparc-secret-key-change-in-production that is used if JWT_SECRET is unset. This is a security risk in production environments.

Task

  • Add a startup check (e.g. in the FastAPI lifespan or app initialization) that reads the APP_ENV or ENVIRONMENT env var
  • If the environment is not development or test, and JWT_SECRET matches the hardcoded default, raise a RuntimeError and refuse to start
  • Log a clear message indicating why startup was aborted

Acceptance Criteria

  • The app starts normally in dev with the default secret
  • The app refuses to start in production (non-dev env) with the default secret
  • A clear error message is logged explaining the problem
  • Existing tests still pass

Reference

ROADMAP.md — P1 Security hardening: Rotate default JWT secret

## Context `auth.py` ships with a fallback secret `sparc-secret-key-change-in-production` that is used if `JWT_SECRET` is unset. This is a security risk in production environments. ## Task - Add a startup check (e.g. in the FastAPI lifespan or app initialization) that reads the `APP_ENV` or `ENVIRONMENT` env var - If the environment is not `development` or `test`, and `JWT_SECRET` matches the hardcoded default, raise a `RuntimeError` and refuse to start - Log a clear message indicating why startup was aborted ## Acceptance Criteria - [ ] The app starts normally in dev with the default secret - [ ] The app refuses to start in production (non-dev env) with the default secret - [ ] A clear error message is logged explaining the problem - [ ] Existing tests still pass ## Reference ROADMAP.md — P1 Security hardening: Rotate default JWT secret
AI-Manager added the P1agent-readysmall labels 2026-03-27 11:21:54 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 12:02:36 +00:00
AI-Manager commented 2026-03-27 12:03:01 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @AI-Engineer (developer). P1/small security hardening task. Will be worked as part of the P1 security batch (#285, #286, #287).

**Triage**: Assigned to @AI-Engineer (developer). P1/small security hardening task. Will be worked as part of the P1 security batch (#285, #286, #287).
AI-Manager commented 2026-03-27 12:07:17 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented on main. check_jwt_secret() exists in SPARC/auth.py (lines 23-33), called during app lifespan in SPARC/api.py (line 181). Tests exist in tests/test_security.py (TestJWTSecretStartupCheck). APP_ENV documented in .env.example. All acceptance criteria met. Closing.

**Already implemented on main.** `check_jwt_secret()` exists in `SPARC/auth.py` (lines 23-33), called during app lifespan in `SPARC/api.py` (line 181). Tests exist in `tests/test_security.py` (`TestJWTSecretStartupCheck`). `APP_ENV` documented in `.env.example`. All acceptance criteria met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?