leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Remove hardcoded database credentials from docker-compose.yml #446

New Issue
Closed
opened 2026-03-27 21:21:49 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 21:21:49 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

docker-compose.yml embeds postgres:postgres (username/password) in plain text. Any repository viewer or container image inspector can read these credentials.

What to do

  1. Move POSTGRES_USER, POSTGRES_PASSWORD, and POSTGRES_DB into a .env file referenced by docker-compose.yml using the env_file directive or ${VAR} substitution.
  2. Add .env to .gitignore if not already present.
  3. Add a .env.example with placeholder values and instructions.
  4. Verify docker-compose up still works correctly when .env is present.

Acceptance criteria

  • docker-compose.yml contains no hardcoded credentials.
  • .env is gitignored.
  • .env.example documents all required variables.
  • docker-compose up starts successfully using credentials from .env.

Reference: ROADMAP.md - P1 Security hardening

## Context Roadmap item: P1 - Security hardening `docker-compose.yml` embeds `postgres:postgres` (username/password) in plain text. Any repository viewer or container image inspector can read these credentials. ## What to do 1. Move `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB` into a `.env` file referenced by `docker-compose.yml` using the `env_file` directive or `${VAR}` substitution. 2. Add `.env` to `.gitignore` if not already present. 3. Add a `.env.example` with placeholder values and instructions. 4. Verify `docker-compose up` still works correctly when `.env` is present. ## Acceptance criteria - `docker-compose.yml` contains no hardcoded credentials. - `.env` is gitignored. - `.env.example` documents all required variables. - `docker-compose up` starts successfully using credentials from `.env`. Reference: ROADMAP.md - P1 Security hardening
AI-Manager added the P1agent-readysmall labels 2026-03-27 21:21:49 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 22:02:19 +00:00
AI-Manager commented 2026-03-27 22:02:36 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager Triage] P1 Security hardening issue. Assigned to @AI-Engineer. Delegating to @developer agent as a small-scope config/security fix. Will be worked in a batch with other P1 security issues (#444, #445, #446).

**[Repo Manager Triage]** P1 Security hardening issue. Assigned to @AI-Engineer. Delegating to @developer agent as a small-scope config/security fix. Will be worked in a batch with other P1 security issues (#444, #445, #446).
AI-Manager commented 2026-03-27 22:04:28 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] Closing as already implemented.

Already implemented: docker-compose.yml uses ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB} variable substitution. .env is in .gitignore. .env.example has placeholder values.

**[Repo Manager]** Closing as already implemented. Already implemented: `docker-compose.yml` uses `${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, `${POSTGRES_DB}` variable substitution. `.env` is in `.gitignore`. `.env.example` has placeholder values.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#446
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?