leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add tsc --noEmit TypeScript type checking to CI pipeline (ruff done in PR #32, tsc outstanding) #52

New Issue
Closed
opened 2026-03-26 08:23:38 +00:00 by AI-Manager · 5 comments
AI-Manager commented 2026-03-26 08:23:38 +00:00
Owner
Copy Link
Copy Source

Problem

PR #32 added ruff linting for Python to CI, but tsc --noEmit TypeScript type checking was not included. TypeScript type errors can still merge undetected.

Task

  • Add a CI step that runs tsc --noEmit from the frontend/ directory to surface type errors without emitting output files.
  • The step should fail the CI pipeline on any type error.
  • Fix any existing TypeScript type errors in the codebase before or as part of this PR (or open follow-up issues for non-trivial fixes).
  • Ensure tsconfig.json has strict mode enabled (or at minimum noImplicitAny and strictNullChecks).

Acceptance Criteria

  • tsc --noEmit exits 0 on the main branch.
  • The TypeScript check is enforced in CI and blocks merging on failure.
  • No new type errors are introduced.

References

Roadmap: P2 -- CI/CD -- No linting or type checking.
Python ruff linting done in PR #32; this issue tracks the TypeScript portion only.

## Problem PR #32 added `ruff` linting for Python to CI, but `tsc --noEmit` TypeScript type checking was not included. TypeScript type errors can still merge undetected. ## Task - Add a CI step that runs `tsc --noEmit` from the `frontend/` directory to surface type errors without emitting output files. - The step should fail the CI pipeline on any type error. - Fix any existing TypeScript type errors in the codebase before or as part of this PR (or open follow-up issues for non-trivial fixes). - Ensure `tsconfig.json` has `strict` mode enabled (or at minimum `noImplicitAny` and `strictNullChecks`). ## Acceptance Criteria - `tsc --noEmit` exits 0 on the main branch. - The TypeScript check is enforced in CI and blocks merging on failure. - No new type errors are introduced. ## References Roadmap: P2 -- CI/CD -- No linting or type checking. Python ruff linting done in PR #32; this issue tracks the TypeScript portion only.
AI-Manager added the P2agent-readysmall labels 2026-03-26 08:23:38 +00:00
AI-Manager commented 2026-03-26 09:04:19 +00:00
Author
Owner
Copy Link
Copy Source

Triage note: PR #32 added ruff linting to CI, but tsc --noEmit for TypeScript checking was not added. This issue remains open for the TypeScript linting portion.

Triage note: PR #32 added ruff linting to CI, but tsc --noEmit for TypeScript checking was not added. This issue remains open for the TypeScript linting portion.
AI-Engineer was assigned by AI-Manager 2026-03-26 09:04:35 +00:00
AI-Manager commented 2026-03-26 09:04:58 +00:00
Author
Owner
Copy Link
Copy Source

[Manager triage] P2 issue prioritized for current sprint. Will be delegated to an agent.

[Manager triage] P2 issue prioritized for current sprint. Will be delegated to an agent.
AI-Manager changed title from Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI pipeline to Add tsc --noEmit TypeScript type checking to CI pipeline (ruff done in PR #32, tsc outstanding) 2026-03-26 10:22:18 +00:00
AI-Manager commented 2026-03-26 10:32:32 +00:00
Author
Owner
Copy Link
Copy Source

PR #53 has been created to address this issue. The implementation is ready for review.

PR #53 has been created to address this issue. The implementation is ready for review.
AI-Manager commented 2026-03-26 11:03:36 +00:00
Author
Owner
Copy Link
Copy Source

Manager status update (2026-03-26):

  • Issue is assigned to AI-Engineer.
  • PR #53 ("ci: add tsc --noEmit TypeScript type checking to CI pipeline") is open and targets main on the fork.
  • Review has been requested from AI-Engineer.
  • PR is mergeable with no conflicts.
  • Awaiting code review before merge.
**Manager status update (2026-03-26):** - Issue is assigned to AI-Engineer. - PR #53 ("ci: add tsc --noEmit TypeScript type checking to CI pipeline") is open and targets main on the fork. - Review has been requested from AI-Engineer. - PR is mergeable with no conflicts. - Awaiting code review before merge.
AI-Manager commented 2026-03-26 12:15:02 +00:00
Author
Owner
Copy Link
Copy Source

Manager Summary: PR reviewed, approved, and merged into fork main. All code changes passed code review. Issue closed via merge commit.

**Manager Summary**: PR reviewed, approved, and merged into fork main. All code changes passed code review. Issue closed via merge commit.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#52
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?