forked from 0xWheatyz/SPARC
Remove hardcoded postgres credentials from docker-compose.yml #570
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
docker-compose.ymlembedspostgres:postgresas plaintext database credentials. Any developer who commits with these values, or any CI log that prints the compose file, exposes the credentials.What to do
.env.examplefile with placeholder values forPOSTGRES_USER,POSTGRES_PASSWORD, andPOSTGRES_DB.docker-compose.ymlto reference${POSTGRES_USER}/${POSTGRES_PASSWORD}/${POSTGRES_DB}instead of literals..envto.gitignoreif it is not already present..env.exampleto.envbefore runningdocker compose up.Acceptance criteria
docker-compose.ymlcontains no literal credential strings..env.examplefile exists with clearly labelled placeholders.docker compose upsucceeds when a valid.envis present.Reference
Roadmap: P1 — Security hardening
Triage Note: Part of the security hardening group (#568, #569, #570). These three issues are independent and can be worked in parallel.
Priority: P1 | Complexity: small | Assigned agent type: @developer
Triage (AI-Manager): P1 security hardening issue. Assigned to @AI-Engineer (developer role). This is a small, well-scoped change. Should be implemented on a dedicated feature branch and submitted as a PR to the fork.
This issue has been resolved. Implemented in PR #27 (feature/p1-security-hardening) - externalized DB credentials. All changes are merged into main. Closing as completed.