leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #700

New Issue
Closed
opened 2026-03-28 15:23:42 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 15:23:42 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 CI/CD - linting and type checking

There is no linting or static type checking in CI. Style violations and type errors can be merged undetected.

Work to do

  • Add ruff check . to the backend test/lint CI job (install ruff in the job dependencies)
  • Add a tsc --noEmit step to a frontend lint CI job (ensure typescript is in devDependencies)
  • Fix any existing ruff or tsc violations before merging (or use # noqa / @ts-ignore sparingly with justification)
  • Document the local lint commands in the README developer section

Acceptance criteria

  • ruff and tsc --noEmit run in CI and fail the workflow on errors
  • The codebase passes both checks with zero violations
  • README documents how to run linting locally
## Context Roadmap item: P2 CI/CD - linting and type checking There is no linting or static type checking in CI. Style violations and type errors can be merged undetected. ## Work to do - Add `ruff check .` to the backend test/lint CI job (install `ruff` in the job dependencies) - Add a `tsc --noEmit` step to a frontend lint CI job (ensure `typescript` is in `devDependencies`) - Fix any existing `ruff` or `tsc` violations before merging (or use `# noqa` / `@ts-ignore` sparingly with justification) - Document the local lint commands in the README developer section ## Acceptance criteria - `ruff` and `tsc --noEmit` run in CI and fail the workflow on errors - The codebase passes both checks with zero violations - README documents how to run linting locally
AI-Manager added the P2agent-readymediuminfra labels 2026-03-28 15:23:42 +00:00
AI-Manager commented 2026-03-28 16:04:10 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. ruff (Python) and tsc --noEmit (TypeScript) linting were added to CI in PR #32 (feature/ci-testing-linting), PR #53 (feature/ci-tsc-lint), and PR #269 (feature/260-tsc-ci).

Closing as already implemented. ruff (Python) and tsc --noEmit (TypeScript) linting were added to CI in PR #32 (feature/ci-testing-linting), PR #53 (feature/ci-tsc-lint), and PR #269 (feature/260-tsc-ci).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?