leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #84

New Issue
Closed
opened 2026-03-26 14:23:44 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 14:23:44 +00:00
Owner
Copy Link
Copy Source

Context

Neither Python linting (ruff) nor TypeScript type checking (tsc --noEmit) runs in CI. Style and type errors go undetected until code review.

Work

  • Add a lint CI job (or steps within the existing test job) that:
    • Runs ruff check . on the backend Python code.
    • Runs tsc --noEmit on the frontend TypeScript code.
  • Fix any existing linting or type errors so the job passes on the current main branch.
  • Add ruff to requirements-dev.txt (or equivalent) if not already present.
  • Ensure tsconfig.json is configured correctly for tsc --noEmit.

Acceptance Criteria

  • ruff check . passes on the backend with zero errors.
  • tsc --noEmit passes on the frontend with zero errors.
  • Both checks run in CI and block the build if they fail.
  • New PRs with linting/type errors are caught automatically.

References

Roadmap: CI/CD — no linting or type checking.

## Context Neither Python linting (`ruff`) nor TypeScript type checking (`tsc --noEmit`) runs in CI. Style and type errors go undetected until code review. ## Work - Add a `lint` CI job (or steps within the existing `test` job) that: - Runs `ruff check .` on the backend Python code. - Runs `tsc --noEmit` on the frontend TypeScript code. - Fix any existing linting or type errors so the job passes on the current main branch. - Add `ruff` to `requirements-dev.txt` (or equivalent) if not already present. - Ensure `tsconfig.json` is configured correctly for `tsc --noEmit`. ## Acceptance Criteria - `ruff check .` passes on the backend with zero errors. - `tsc --noEmit` passes on the frontend with zero errors. - Both checks run in CI and block the build if they fail. - New PRs with linting/type errors are caught automatically. ## References Roadmap: CI/CD — no linting or type checking.
AI-Manager added the P2agent-readymedium labels 2026-03-26 14:23:44 +00:00
AI-Manager commented 2026-03-26 15:06:26 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. Both ruff (Python) and tsc --noEmit (TypeScript) linting added to CI. Implemented in PR #32 (ruff) and PR #53 (tsc), both merged. See .gitea/workflows/build.yaml.

Resolved. Both ruff (Python) and tsc --noEmit (TypeScript) linting added to CI. Implemented in PR #32 (ruff) and PR #53 (tsc), both merged. See `.gitea/workflows/build.yaml`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#84
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?