Compare commits
16 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 062f85cf1b | |||
| d34916c276 | |||
| d350500486 | |||
| f802ad296c | |||
| 9ac282ba17 | |||
| 2cc1f16bce | |||
| c6fdcc8a11 | |||
| baf6977a33 | |||
| f1e4b0c2ba | |||
| fa63d56e43 | |||
| d8a590eb79 | |||
| 46d23bf565 | |||
| c7d68c742d | |||
| 674c75f5eb | |||
| 4e7b072f82 | |||
| 02a108a58e |
@@ -4,6 +4,9 @@ on:
|
|||||||
push:
|
push:
|
||||||
branches:
|
branches:
|
||||||
- master
|
- master
|
||||||
|
pull_request:
|
||||||
|
branches:
|
||||||
|
- master
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
test:
|
test:
|
||||||
@@ -24,6 +27,7 @@ jobs:
|
|||||||
build:
|
build:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
needs: test
|
needs: test
|
||||||
|
if: gitea.event_name == 'push'
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
|||||||
+1
-1
@@ -1,7 +1,7 @@
|
|||||||
# Stage 1: Build
|
# Stage 1: Build
|
||||||
FROM golang:1.22-alpine AS builder
|
FROM golang:1.22-alpine AS builder
|
||||||
WORKDIR /app
|
WORKDIR /app
|
||||||
COPY go.mod ./
|
COPY go.mod go.sum ./
|
||||||
RUN go mod download
|
RUN go mod download
|
||||||
COPY . .
|
COPY . .
|
||||||
RUN CGO_ENABLED=0 GOOS=linux go build -ldflags="-s -w" -o /gitea-mobile ./cmd/server
|
RUN CGO_ENABLED=0 GOOS=linux go build -ldflags="-s -w" -o /gitea-mobile ./cmd/server
|
||||||
|
|||||||
+32
-1
@@ -1,10 +1,14 @@
|
|||||||
package main
|
package main
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"context"
|
||||||
"log"
|
"log"
|
||||||
"log/slog"
|
"log/slog"
|
||||||
"net/http"
|
"net/http"
|
||||||
"os"
|
"os"
|
||||||
|
"os/signal"
|
||||||
|
"syscall"
|
||||||
|
"time"
|
||||||
|
|
||||||
"gitea.leeworks.dev/0xwheatyz/gitea-mobile/internal/config"
|
"gitea.leeworks.dev/0xwheatyz/gitea-mobile/internal/config"
|
||||||
giteaclient "gitea.leeworks.dev/0xwheatyz/gitea-mobile/internal/gitea"
|
giteaclient "gitea.leeworks.dev/0xwheatyz/gitea-mobile/internal/gitea"
|
||||||
@@ -36,8 +40,35 @@ func main() {
|
|||||||
handler = middleware.Auth(cfg.SessionSecret, cfg.GiteaToken)(handler)
|
handler = middleware.Auth(cfg.SessionSecret, cfg.GiteaToken)(handler)
|
||||||
handler = middleware.Logging()(handler)
|
handler = middleware.Logging()(handler)
|
||||||
|
|
||||||
|
srv := &http.Server{
|
||||||
|
Addr: cfg.ListenAddr,
|
||||||
|
Handler: handler,
|
||||||
|
}
|
||||||
|
|
||||||
|
// Channel to receive shutdown signals.
|
||||||
|
quit := make(chan os.Signal, 1)
|
||||||
|
signal.Notify(quit, syscall.SIGTERM, syscall.SIGINT)
|
||||||
|
|
||||||
|
// Start server in a goroutine.
|
||||||
|
go func() {
|
||||||
slog.Info("server starting", "addr", cfg.ListenAddr, "gitea_url", cfg.GiteaURL)
|
slog.Info("server starting", "addr", cfg.ListenAddr, "gitea_url", cfg.GiteaURL)
|
||||||
if err := http.ListenAndServe(cfg.ListenAddr, handler); err != nil {
|
if err := srv.ListenAndServe(); err != nil && err != http.ErrServerClosed {
|
||||||
log.Fatalf("server error: %v", err)
|
log.Fatalf("server error: %v", err)
|
||||||
}
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
|
// Block until a shutdown signal is received.
|
||||||
|
sig := <-quit
|
||||||
|
slog.Info("shutdown signal received, draining in-flight requests", "signal", sig.String())
|
||||||
|
|
||||||
|
// Give in-flight requests up to 15 seconds to complete.
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
|
||||||
|
if err := srv.Shutdown(ctx); err != nil {
|
||||||
|
slog.Error("server forced to shutdown", "error", err)
|
||||||
|
os.Exit(1)
|
||||||
|
}
|
||||||
|
|
||||||
|
slog.Info("server stopped gracefully")
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -760,6 +760,33 @@ func (c *Client) GetPull(ctx context.Context, token, owner, repo string, index i
|
|||||||
return &pr, nil
|
return &pr, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ChangedFile represents a file changed in a pull request.
|
||||||
|
type ChangedFile struct {
|
||||||
|
Filename string `json:"filename"`
|
||||||
|
Status string `json:"status"` // "added", "modified", "removed", "renamed"
|
||||||
|
Additions int `json:"additions"`
|
||||||
|
Deletions int `json:"deletions"`
|
||||||
|
Changes int `json:"changes"`
|
||||||
|
PreviousFilename string `json:"previous_filename,omitempty"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetChangedFiles fetches the list of files changed in a pull request.
|
||||||
|
func (c *Client) GetChangedFiles(ctx context.Context, token, owner, repo string, index int64) ([]ChangedFile, error) {
|
||||||
|
path := fmt.Sprintf("/repos/%s/%s/pulls/%d/files?limit=50", owner, repo, index)
|
||||||
|
resp, err := c.doRequest(ctx, token, http.MethodGet, path, nil)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("fetching changed files: %w", err)
|
||||||
|
}
|
||||||
|
defer resp.Body.Close()
|
||||||
|
|
||||||
|
var files []ChangedFile
|
||||||
|
if err := json.NewDecoder(resp.Body).Decode(&files); err != nil {
|
||||||
|
return nil, fmt.Errorf("decoding changed files: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return files, nil
|
||||||
|
}
|
||||||
|
|
||||||
// GetIssueComments fetches comments for an issue or pull request.
|
// GetIssueComments fetches comments for an issue or pull request.
|
||||||
func (c *Client) GetIssueComments(ctx context.Context, token, owner, repo string, index int64) ([]Comment, error) {
|
func (c *Client) GetIssueComments(ctx context.Context, token, owner, repo string, index int64) ([]Comment, error) {
|
||||||
path := fmt.Sprintf("/repos/%s/%s/issues/%d/comments?limit=50", owner, repo, index)
|
path := fmt.Sprintf("/repos/%s/%s/issues/%d/comments?limit=50", owner, repo, index)
|
||||||
@@ -945,6 +972,40 @@ func (c *Client) SetIssueState(ctx context.Context, token, owner, repo string, i
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// MergePull merges a pull request using the specified merge style.
|
||||||
|
// Valid styles: "merge", "rebase", "rebase-merge", "squash".
|
||||||
|
// If style is empty, defaults to "merge".
|
||||||
|
func (c *Client) MergePull(ctx context.Context, token, owner, repo string, index int64, style, title, message string) error {
|
||||||
|
if style == "" {
|
||||||
|
style = "merge"
|
||||||
|
}
|
||||||
|
|
||||||
|
payload := map[string]string{
|
||||||
|
"Do": style,
|
||||||
|
}
|
||||||
|
if title != "" {
|
||||||
|
payload["merge_message_field"] = title
|
||||||
|
}
|
||||||
|
if message != "" {
|
||||||
|
payload["merge_message_field"] = message
|
||||||
|
}
|
||||||
|
|
||||||
|
jsonData, err := json.Marshal(payload)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("marshaling merge request: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
path := fmt.Sprintf("/repos/%s/%s/pulls/%d/merge", owner, repo, index)
|
||||||
|
resp, err := c.doRequest(ctx, token, http.MethodPost, path, strings.NewReader(string(jsonData)))
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("merging pull request: %w", err)
|
||||||
|
}
|
||||||
|
resp.Body.Close()
|
||||||
|
|
||||||
|
c.InvalidateAll()
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// AddComment creates a comment on an issue and returns the created Comment.
|
// AddComment creates a comment on an issue and returns the created Comment.
|
||||||
func (c *Client) AddComment(ctx context.Context, token, owner, repo string, index int64, body string) (*Comment, error) {
|
func (c *Client) AddComment(ctx context.Context, token, owner, repo string, index int64, body string) (*Comment, error) {
|
||||||
return c.PostComment(ctx, token, owner, repo, index, body)
|
return c.PostComment(ctx, token, owner, repo, index, body)
|
||||||
|
|||||||
@@ -1456,3 +1456,141 @@ func TestRetryDelay_ExponentialBackoff(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestGetChangedFiles(t *testing.T) {
|
||||||
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
if r.Method != http.MethodGet {
|
||||||
|
t.Errorf("expected GET, got %s", r.Method)
|
||||||
|
}
|
||||||
|
if r.URL.Path != "/api/v1/repos/owner1/repo1/pulls/5/files" {
|
||||||
|
t.Errorf("unexpected path: %s", r.URL.Path)
|
||||||
|
}
|
||||||
|
if r.Header.Get("Authorization") != "token test-token" {
|
||||||
|
t.Error("missing or wrong Authorization header")
|
||||||
|
}
|
||||||
|
|
||||||
|
files := []ChangedFile{
|
||||||
|
{Filename: "main.go", Status: "modified", Additions: 10, Deletions: 3, Changes: 13},
|
||||||
|
{Filename: "new_file.go", Status: "added", Additions: 25, Deletions: 0, Changes: 25},
|
||||||
|
{Filename: "old_file.go", Status: "removed", Additions: 0, Deletions: 15, Changes: 15},
|
||||||
|
}
|
||||||
|
json.NewEncoder(w).Encode(files)
|
||||||
|
}))
|
||||||
|
defer server.Close()
|
||||||
|
|
||||||
|
c := NewClient(server.URL)
|
||||||
|
files, err := c.GetChangedFiles(context.Background(), "test-token", "owner1", "repo1", 5)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("unexpected error: %v", err)
|
||||||
|
}
|
||||||
|
if len(files) != 3 {
|
||||||
|
t.Fatalf("got %d files, want 3", len(files))
|
||||||
|
}
|
||||||
|
if files[0].Filename != "main.go" {
|
||||||
|
t.Errorf("files[0].Filename = %q, want %q", files[0].Filename, "main.go")
|
||||||
|
}
|
||||||
|
if files[0].Status != "modified" {
|
||||||
|
t.Errorf("files[0].Status = %q, want %q", files[0].Status, "modified")
|
||||||
|
}
|
||||||
|
if files[1].Status != "added" {
|
||||||
|
t.Errorf("files[1].Status = %q, want %q", files[1].Status, "added")
|
||||||
|
}
|
||||||
|
if files[2].Status != "removed" {
|
||||||
|
t.Errorf("files[2].Status = %q, want %q", files[2].Status, "removed")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestGetChangedFiles_Error(t *testing.T) {
|
||||||
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
w.WriteHeader(http.StatusNotFound)
|
||||||
|
fmt.Fprintln(w, `{"message":"pull request not found"}`)
|
||||||
|
}))
|
||||||
|
defer server.Close()
|
||||||
|
|
||||||
|
c := NewClient(server.URL)
|
||||||
|
_, err := c.GetChangedFiles(context.Background(), "test-token", "owner1", "repo1", 999)
|
||||||
|
if err == nil {
|
||||||
|
t.Fatal("expected error for 404 response, got nil")
|
||||||
|
}
|
||||||
|
if !strings.Contains(err.Error(), "404") {
|
||||||
|
t.Errorf("error should contain status code 404, got: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMergePull(t *testing.T) {
|
||||||
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
if r.Method != http.MethodPost {
|
||||||
|
t.Errorf("expected POST, got %s", r.Method)
|
||||||
|
}
|
||||||
|
if r.URL.Path != "/api/v1/repos/owner1/repo1/pulls/5/merge" {
|
||||||
|
t.Errorf("unexpected path: %s", r.URL.Path)
|
||||||
|
}
|
||||||
|
if r.Header.Get("Authorization") != "token test-token" {
|
||||||
|
t.Error("missing or wrong Authorization header")
|
||||||
|
}
|
||||||
|
|
||||||
|
var body map[string]string
|
||||||
|
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
|
||||||
|
t.Fatalf("failed to decode body: %v", err)
|
||||||
|
}
|
||||||
|
if body["Do"] != "squash" {
|
||||||
|
t.Errorf("expected Do=squash, got %q", body["Do"])
|
||||||
|
}
|
||||||
|
|
||||||
|
w.WriteHeader(http.StatusOK)
|
||||||
|
}))
|
||||||
|
defer server.Close()
|
||||||
|
|
||||||
|
c := NewClient(server.URL)
|
||||||
|
c.setCache("pulls-org1", "should-be-invalidated")
|
||||||
|
|
||||||
|
err := c.MergePull(context.Background(), "test-token", "owner1", "repo1", 5, "squash", "", "")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("unexpected error: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Verify cache was invalidated.
|
||||||
|
_, ok := c.getFromCache("pulls-org1")
|
||||||
|
if ok {
|
||||||
|
t.Error("expected cache to be invalidated after MergePull")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMergePull_DefaultStyle(t *testing.T) {
|
||||||
|
var receivedStyle string
|
||||||
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
var body map[string]string
|
||||||
|
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
|
||||||
|
t.Fatalf("failed to decode body: %v", err)
|
||||||
|
}
|
||||||
|
receivedStyle = body["Do"]
|
||||||
|
w.WriteHeader(http.StatusOK)
|
||||||
|
}))
|
||||||
|
defer server.Close()
|
||||||
|
|
||||||
|
c := NewClient(server.URL)
|
||||||
|
err := c.MergePull(context.Background(), "test-token", "owner1", "repo1", 5, "", "", "")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("unexpected error: %v", err)
|
||||||
|
}
|
||||||
|
if receivedStyle != "merge" {
|
||||||
|
t.Errorf("expected default style 'merge', got %q", receivedStyle)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestMergePull_Error(t *testing.T) {
|
||||||
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
w.WriteHeader(http.StatusMethodNotAllowed)
|
||||||
|
fmt.Fprintln(w, `{"message":"not mergeable"}`)
|
||||||
|
}))
|
||||||
|
defer server.Close()
|
||||||
|
|
||||||
|
c := NewClient(server.URL)
|
||||||
|
err := c.MergePull(context.Background(), "test-token", "owner1", "repo1", 5, "merge", "", "")
|
||||||
|
if err == nil {
|
||||||
|
t.Fatal("expected error for 405 response, got nil")
|
||||||
|
}
|
||||||
|
if !strings.Contains(err.Error(), "405") {
|
||||||
|
t.Errorf("error should contain status code 405, got: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -56,6 +56,7 @@ func (h *Handler) RegisterRoutes(mux *http.ServeMux) {
|
|||||||
mux.HandleFunc("GET /pulls/{owner}/{repo}/{index}", h.PullDetail)
|
mux.HandleFunc("GET /pulls/{owner}/{repo}/{index}", h.PullDetail)
|
||||||
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/review", h.SubmitReview)
|
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/review", h.SubmitReview)
|
||||||
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/state", h.SetPullState)
|
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/state", h.SetPullState)
|
||||||
|
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/merge", h.MergePull)
|
||||||
|
|
||||||
// Settings (handled separately for auth bypass).
|
// Settings (handled separately for auth bypass).
|
||||||
settingsHandler := &SettingsHandler{
|
settingsHandler := &SettingsHandler{
|
||||||
@@ -78,6 +79,31 @@ func getToken(r *http.Request) string {
|
|||||||
return middleware.TokenFromContext(r.Context())
|
return middleware.TokenFromContext(r.Context())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// isTokenError returns true if the error indicates an expired or revoked API token.
|
||||||
|
func isTokenError(err error) bool {
|
||||||
|
if err == nil {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
msg := err.Error()
|
||||||
|
return strings.Contains(msg, "API error 401") || strings.Contains(msg, "API error 403")
|
||||||
|
}
|
||||||
|
|
||||||
|
// redirectOnTokenError checks if the error is a token auth error and redirects
|
||||||
|
// to /settings with an error banner. Returns true if a redirect was performed.
|
||||||
|
func redirectOnTokenError(w http.ResponseWriter, r *http.Request, err error) bool {
|
||||||
|
if !isTokenError(err) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
slog.Warn("Gitea API token expired or revoked, redirecting to settings", "error", err)
|
||||||
|
if isHTMX(r) {
|
||||||
|
w.Header().Set("HX-Redirect", "/settings?error=token_expired")
|
||||||
|
w.WriteHeader(http.StatusOK)
|
||||||
|
} else {
|
||||||
|
http.Redirect(w, r, "/settings?error=token_expired", http.StatusSeeOther)
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
// getUserOrgs returns the list of org names the user belongs to.
|
// getUserOrgs returns the list of org names the user belongs to.
|
||||||
func (h *Handler) getUserOrgs(r *http.Request) []string {
|
func (h *Handler) getUserOrgs(r *http.Request) []string {
|
||||||
token := getToken(r)
|
token := getToken(r)
|
||||||
@@ -263,6 +289,9 @@ func (h *Handler) Dashboard(w http.ResponseWriter, r *http.Request) {
|
|||||||
|
|
||||||
queue, err := h.Client.GetTriageQueue(r.Context(), token, queryOrgs)
|
queue, err := h.Client.GetTriageQueue(r.Context(), token, queryOrgs)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
if redirectOnTokenError(w, r, err) {
|
||||||
|
return
|
||||||
|
}
|
||||||
slog.Error("failed to get triage queue", "error", err)
|
slog.Error("failed to get triage queue", "error", err)
|
||||||
data.Error = "Error loading triage queue."
|
data.Error = "Error loading triage queue."
|
||||||
} else {
|
} else {
|
||||||
@@ -346,6 +375,9 @@ func (h *Handler) ListIssues(w http.ResponseWriter, r *http.Request) {
|
|||||||
|
|
||||||
result, err := h.Client.ListAllIssues(r.Context(), token, queryOrgs, selectedState, page, selectedLabel, selectedRepo)
|
result, err := h.Client.ListAllIssues(r.Context(), token, queryOrgs, selectedState, page, selectedLabel, selectedRepo)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
if redirectOnTokenError(w, r, err) {
|
||||||
|
return
|
||||||
|
}
|
||||||
slog.Error("failed to list issues", "error", err)
|
slog.Error("failed to list issues", "error", err)
|
||||||
data.Error = "Error loading issues."
|
data.Error = "Error loading issues."
|
||||||
} else {
|
} else {
|
||||||
@@ -451,6 +483,9 @@ func (h *Handler) ListPulls(w http.ResponseWriter, r *http.Request) {
|
|||||||
|
|
||||||
result, err := h.Client.ListAllPullRequests(r.Context(), token, queryOrgs, selectedState, page, selectedLabel, selectedRepo)
|
result, err := h.Client.ListAllPullRequests(r.Context(), token, queryOrgs, selectedState, page, selectedLabel, selectedRepo)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
if redirectOnTokenError(w, r, err) {
|
||||||
|
return
|
||||||
|
}
|
||||||
slog.Error("failed to list pull requests", "error", err)
|
slog.Error("failed to list pull requests", "error", err)
|
||||||
data.Error = "Error loading pull requests."
|
data.Error = "Error loading pull requests."
|
||||||
} else {
|
} else {
|
||||||
@@ -1068,3 +1103,49 @@ func (h *Handler) SubmitReview(w http.ResponseWriter, r *http.Request) {
|
|||||||
|
|
||||||
http.Redirect(w, r, fmt.Sprintf("/pulls/%s/%s/%d", owner, repo, index), http.StatusSeeOther)
|
http.Redirect(w, r, fmt.Sprintf("/pulls/%s/%s/%d", owner, repo, index), http.StatusSeeOther)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// MergePull handles POST /pulls/{owner}/{repo}/{index}/merge.
|
||||||
|
func (h *Handler) MergePull(w http.ResponseWriter, r *http.Request) {
|
||||||
|
token := getToken(r)
|
||||||
|
owner := r.PathValue("owner")
|
||||||
|
repo := r.PathValue("repo")
|
||||||
|
indexStr := r.PathValue("index")
|
||||||
|
|
||||||
|
index, err := strconv.ParseInt(indexStr, 10, 64)
|
||||||
|
if err != nil {
|
||||||
|
http.Error(w, "invalid PR index", http.StatusBadRequest)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := r.ParseForm(); err != nil {
|
||||||
|
http.Error(w, "bad request", http.StatusBadRequest)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
style := r.FormValue("Do")
|
||||||
|
if style == "" {
|
||||||
|
style = "merge"
|
||||||
|
}
|
||||||
|
title := r.FormValue("merge_title")
|
||||||
|
message := r.FormValue("merge_message")
|
||||||
|
|
||||||
|
if err := h.Client.MergePull(r.Context(), token, owner, repo, index, style, title, message); err != nil {
|
||||||
|
slog.Error("failed to merge pull request", "error", err, "owner", owner, "repo", repo, "index", index)
|
||||||
|
if isHTMX(r) {
|
||||||
|
w.Header().Set("Content-Type", "text/html; charset=utf-8")
|
||||||
|
w.WriteHeader(http.StatusInternalServerError)
|
||||||
|
fmt.Fprint(w, `<span style="color:#f85149">Failed to merge pull request.</span>`)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
http.Error(w, "failed to merge pull request", http.StatusInternalServerError)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
if isHTMX(r) {
|
||||||
|
w.Header().Set("Content-Type", "text/html; charset=utf-8")
|
||||||
|
fmt.Fprint(w, `<span style="color:#a371f7;font-weight:bold">Merged</span>`)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
http.Redirect(w, r, fmt.Sprintf("/pulls/%s/%s/%d", owner, repo, index), http.StatusSeeOther)
|
||||||
|
}
|
||||||
|
|||||||
@@ -185,6 +185,11 @@ func mockGiteaAPI(t *testing.T) *httptest.Server {
|
|||||||
json.NewEncoder(w).Encode(map[string]interface{}{"id": 1, "state": "APPROVED"})
|
json.NewEncoder(w).Encode(map[string]interface{}{"id": 1, "state": "APPROVED"})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// POST /api/v1/repos/{owner}/{repo}/pulls/{index}/merge — merge PR.
|
||||||
|
mux.HandleFunc("POST /api/v1/repos/{owner}/{repo}/pulls/{index}/merge", func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
w.WriteHeader(http.StatusOK)
|
||||||
|
})
|
||||||
|
|
||||||
// POST /api/v1/markdown — render markdown.
|
// POST /api/v1/markdown — render markdown.
|
||||||
mux.HandleFunc("POST /api/v1/markdown", func(w http.ResponseWriter, r *http.Request) {
|
mux.HandleFunc("POST /api/v1/markdown", func(w http.ResponseWriter, r *http.Request) {
|
||||||
w.Header().Set("Content-Type", "text/html")
|
w.Header().Set("Content-Type", "text/html")
|
||||||
@@ -917,6 +922,67 @@ func TestIntegration_SubmitReview_RequestChanges(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// --- Issue #229: Integration tests for POST /pulls/{owner}/{repo}/{index}/merge ---
|
||||||
|
|
||||||
|
func TestIntegration_MergePull_Valid(t *testing.T) {
|
||||||
|
h, srv := newTestHandlerWithMock(t)
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
mux := http.NewServeMux()
|
||||||
|
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/merge", h.MergePull)
|
||||||
|
|
||||||
|
form := url.Values{"Do": {"merge"}}
|
||||||
|
req := reqWithToken(http.MethodPost, "/pulls/test-org/repo1/1/merge", form.Encode())
|
||||||
|
w := httptest.NewRecorder()
|
||||||
|
|
||||||
|
mux.ServeHTTP(w, req)
|
||||||
|
|
||||||
|
if w.Code != http.StatusSeeOther {
|
||||||
|
t.Errorf("status = %d, want %d", w.Code, http.StatusSeeOther)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestIntegration_MergePull_HTMX(t *testing.T) {
|
||||||
|
h, srv := newTestHandlerWithMock(t)
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
mux := http.NewServeMux()
|
||||||
|
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/merge", h.MergePull)
|
||||||
|
|
||||||
|
form := url.Values{"Do": {"squash"}}
|
||||||
|
req := reqWithToken(http.MethodPost, "/pulls/test-org/repo1/1/merge", form.Encode())
|
||||||
|
req.Header.Set("HX-Request", "true")
|
||||||
|
w := httptest.NewRecorder()
|
||||||
|
|
||||||
|
mux.ServeHTTP(w, req)
|
||||||
|
|
||||||
|
if w.Code != http.StatusOK {
|
||||||
|
t.Errorf("status = %d, want %d", w.Code, http.StatusOK)
|
||||||
|
}
|
||||||
|
body := w.Body.String()
|
||||||
|
if !contains(body, "Merged") {
|
||||||
|
t.Errorf("expected 'Merged' in HTMX response, got: %s", body)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestIntegration_MergePull_DefaultStyle(t *testing.T) {
|
||||||
|
h, srv := newTestHandlerWithMock(t)
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
mux := http.NewServeMux()
|
||||||
|
mux.HandleFunc("POST /pulls/{owner}/{repo}/{index}/merge", h.MergePull)
|
||||||
|
|
||||||
|
// No "Do" form value — should default to "merge".
|
||||||
|
req := reqWithToken(http.MethodPost, "/pulls/test-org/repo1/1/merge", "")
|
||||||
|
w := httptest.NewRecorder()
|
||||||
|
|
||||||
|
mux.ServeHTTP(w, req)
|
||||||
|
|
||||||
|
if w.Code != http.StatusSeeOther {
|
||||||
|
t.Errorf("status = %d, want %d", w.Code, http.StatusSeeOther)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// --- Issue #110: Integration tests for POST /issues/{owner}/{repo}/{index}/labels ---
|
// --- Issue #110: Integration tests for POST /issues/{owner}/{repo}/{index}/labels ---
|
||||||
|
|
||||||
func TestIntegration_ApplyLabels_Valid(t *testing.T) {
|
func TestIntegration_ApplyLabels_Valid(t *testing.T) {
|
||||||
|
|||||||
@@ -45,6 +45,13 @@ func (h *SettingsHandler) handleGet(w http.ResponseWriter, r *http.Request) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
data := settingsData{HasToken: hasToken}
|
data := settingsData{HasToken: hasToken}
|
||||||
|
|
||||||
|
// Show error banner when redirected due to expired/revoked token.
|
||||||
|
if r.URL.Query().Get("error") == "token_expired" {
|
||||||
|
data.Message = "Your Gitea API token is expired or has been revoked. Please enter a new token."
|
||||||
|
data.MessageType = "error"
|
||||||
|
}
|
||||||
|
|
||||||
h.renderSettings(w, data)
|
h.renderSettings(w, data)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -14,7 +14,7 @@
|
|||||||
</span>
|
</span>
|
||||||
<span>{{.Issue.RepoOwner}}/{{.Issue.RepoName}} #{{.Issue.Number}}</span>
|
<span>{{.Issue.RepoOwner}}/{{.Issue.RepoName}} #{{.Issue.Number}}</span>
|
||||||
{{range .Issue.Labels}}
|
{{range .Issue.Labels}}
|
||||||
<span class="label" style="color:#{{.Color}};border:1px solid #{{.Color}}">{{.Name}}</span>
|
<span class="label label-pill" style="background-color:#{{.Color}};color:#fff;border:1px solid #{{.Color}}">{{.Name}}</span>
|
||||||
{{end}}
|
{{end}}
|
||||||
</div>
|
</div>
|
||||||
{{if .RenderedBody}}
|
{{if .RenderedBody}}
|
||||||
|
|||||||
@@ -5,7 +5,7 @@
|
|||||||
<div class="card-meta">
|
<div class="card-meta">
|
||||||
<span>{{.RepoOwner}}/{{.RepoName}} #{{.Number}}</span>
|
<span>{{.RepoOwner}}/{{.RepoName}} #{{.Number}}</span>
|
||||||
{{range .Labels}}
|
{{range .Labels}}
|
||||||
<span class="label" style="color:#{{.Color}};border:1px solid #{{.Color}}">{{.Name}}</span>
|
<span class="label label-pill" style="background-color:#{{.Color}};color:#fff;border:1px solid #{{.Color}}">{{.Name}}</span>
|
||||||
{{end}}
|
{{end}}
|
||||||
{{if .Assignee}}
|
{{if .Assignee}}
|
||||||
<img src="{{.Assignee.AvatarURL}}" alt="{{.Assignee.Login}}" class="avatar" title="Assigned to {{.Assignee.Login}}">
|
<img src="{{.Assignee.AvatarURL}}" alt="{{.Assignee.Login}}" class="avatar" title="Assigned to {{.Assignee.Login}}">
|
||||||
|
|||||||
@@ -7,7 +7,7 @@
|
|||||||
{{if eq .Pull.State "closed"}}<span class="state-closed">{{.Pull.State}}</span>{{else}}<span class="state-open">{{.Pull.State}}</span>{{end}}
|
{{if eq .Pull.State "closed"}}<span class="state-closed">{{.Pull.State}}</span>{{else}}<span class="state-open">{{.Pull.State}}</span>{{end}}
|
||||||
<span>{{.Pull.RepoOwner}}/{{.Pull.RepoName}} #{{.Pull.Number}}</span>
|
<span>{{.Pull.RepoOwner}}/{{.Pull.RepoName}} #{{.Pull.Number}}</span>
|
||||||
{{range .Pull.Labels}}
|
{{range .Pull.Labels}}
|
||||||
<span class="label" style="color:#{{.Color}};border:1px solid #{{.Color}}">{{.Name}}</span>
|
<span class="label label-pill" style="background-color:#{{.Color}};color:#fff;border:1px solid #{{.Color}}">{{.Name}}</span>
|
||||||
{{end}}
|
{{end}}
|
||||||
</div>
|
</div>
|
||||||
<div class="card-meta" style="margin-top:0.5rem;">
|
<div class="card-meta" style="margin-top:0.5rem;">
|
||||||
@@ -33,6 +33,23 @@
|
|||||||
{{end}}
|
{{end}}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{{if and .Pull.Mergeable (eq .Pull.State "open")}}
|
||||||
|
<div class="card" style="margin-top:1rem;" id="merge-section">
|
||||||
|
<h2>Merge Pull Request</h2>
|
||||||
|
<form hx-post="/pulls/{{.Pull.RepoOwner}}/{{.Pull.RepoName}}/{{.Pull.Number}}/merge" hx-target="#merge-section" hx-swap="innerHTML">
|
||||||
|
<div class="form-group">
|
||||||
|
<label for="merge-style">Merge Style</label>
|
||||||
|
<select id="merge-style" name="Do">
|
||||||
|
<option value="merge">Merge Commit</option>
|
||||||
|
<option value="rebase">Rebase</option>
|
||||||
|
<option value="squash">Squash</option>
|
||||||
|
</select>
|
||||||
|
</div>
|
||||||
|
<button type="submit" class="btn btn-primary" style="background-color:var(--accent-purple,#a371f7);">Merge PR</button>
|
||||||
|
</form>
|
||||||
|
</div>
|
||||||
|
{{end}}
|
||||||
|
|
||||||
<div class="card" style="margin-top:1rem;">
|
<div class="card" style="margin-top:1rem;">
|
||||||
<h2>Submit Review</h2>
|
<h2>Submit Review</h2>
|
||||||
<form hx-post="/pulls/{{.Pull.RepoOwner}}/{{.Pull.RepoName}}/{{.Pull.Number}}/review" hx-swap="outerHTML">
|
<form hx-post="/pulls/{{.Pull.RepoOwner}}/{{.Pull.RepoName}}/{{.Pull.Number}}/review" hx-swap="outerHTML">
|
||||||
|
|||||||
@@ -8,7 +8,7 @@
|
|||||||
<div class="card-meta">
|
<div class="card-meta">
|
||||||
<span>{{.RepoOwner}}/{{.RepoName}} #{{.Number}}</span>
|
<span>{{.RepoOwner}}/{{.RepoName}} #{{.Number}}</span>
|
||||||
{{range .Labels}}
|
{{range .Labels}}
|
||||||
<span class="label" style="color:#{{.Color}};border:1px solid #{{.Color}}">{{.Name}}</span>
|
<span class="label label-pill" style="background-color:#{{.Color}};color:#fff;border:1px solid #{{.Color}}">{{.Name}}</span>
|
||||||
{{end}}
|
{{end}}
|
||||||
<span class="diff-add">+{{.Additions}}</span>
|
<span class="diff-add">+{{.Additions}}</span>
|
||||||
<span class="diff-del">-{{.Deletions}}</span>
|
<span class="diff-del">-{{.Deletions}}</span>
|
||||||
|
|||||||
@@ -176,6 +176,11 @@ a:active {
|
|||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.label-pill {
|
||||||
|
text-shadow: 0 1px 2px rgba(0, 0, 0, 0.4);
|
||||||
|
font-weight: 600;
|
||||||
|
}
|
||||||
|
|
||||||
.type-badge {
|
.type-badge {
|
||||||
font-size: 0.65rem;
|
font-size: 0.65rem;
|
||||||
text-transform: uppercase;
|
text-transform: uppercase;
|
||||||
|
|||||||
Reference in New Issue
Block a user