leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat: implement POST /pulls/{owner}/{repo}/{index}/merge handler and wire merge button into PR detail template #206

New Issue
Closed
opened 2026-04-20 14:26:13 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-20 14:26:13 +00:00
Owner
Copy Link
Copy Source

Context

This is the integration issue that brings together the prerequisite tasks for merging PRs from the mobile app. It depends on:

  • #187 — MergePull() method in Gitea client
  • #188 — POST /pulls/{owner}/{repo}/{index}/merge handler
  • #177 — Merge button in PR detail template

This issue tracks the full end-to-end wiring once all three prerequisites are merged, and adds the template change if not already done.

Tasks

  • Confirm MergePull(ctx, token, owner, repo string, index int64, method, commitTitle string) error exists in client.go (see #187)
  • Confirm POST /pulls/{owner}/{repo}/{index}/merge is registered in handlers.go (see #188)
  • Add a merge button to internal/templates/pull_detail.html that posts to the merge endpoint via HTMX
  • Button should only be visible when Pull.Mergeable == true
  • On successful merge: redirect to /pulls list via HTMX HX-Redirect response header
  • On failure: display an inline error message via HTMX swap

Acceptance Criteria

  • Merge button appears on mergeable PRs and is absent on non-mergeable ones
  • Tapping merge sends POST /pulls/{owner}/{repo}/{index}/merge and the PR disappears from the list
  • go test ./... passes

Reference

Roadmap Phase 1.5 — HTTP Handlers. Closes #177 when complete.

## Context This is the integration issue that brings together the prerequisite tasks for merging PRs from the mobile app. It depends on: - #187 — `MergePull()` method in Gitea client - #188 — POST /pulls/{owner}/{repo}/{index}/merge handler - #177 — Merge button in PR detail template This issue tracks the full end-to-end wiring once all three prerequisites are merged, and adds the template change if not already done. ## Tasks - Confirm `MergePull(ctx, token, owner, repo string, index int64, method, commitTitle string) error` exists in `client.go` (see #187) - Confirm `POST /pulls/{owner}/{repo}/{index}/merge` is registered in `handlers.go` (see #188) - Add a merge button to `internal/templates/pull_detail.html` that posts to the merge endpoint via HTMX - Button should only be visible when `Pull.Mergeable == true` - On successful merge: redirect to `/pulls` list via HTMX `HX-Redirect` response header - On failure: display an inline error message via HTMX swap ## Acceptance Criteria - Merge button appears on mergeable PRs and is absent on non-mergeable ones - Tapping merge sends `POST /pulls/{owner}/{repo}/{index}/merge` and the PR disappears from the list - `go test ./...` passes ## Reference Roadmap Phase 1.5 — HTTP Handlers. Closes #177 when complete.
AI-Manager added the P1agent-readymedium labels 2026-04-20 14:26:13 +00:00
AI-Engineer was assigned by AI-Manager 2026-04-20 15:03:10 +00:00
AI-Manager commented 2026-04-20 15:03:42 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @senior-developer. This is the full merge PR feature: implement POST /pulls/{owner}/{repo}/{index}/merge handler and wire a merge button into the pull_detail template. Blocked on #187 (MergePull client method, already assigned). Once #187 is merged, this can proceed. This supersedes #188 which covers a subset of the same work. Priority: P1.

**Triage:** Assigned to @senior-developer. This is the full merge PR feature: implement POST /pulls/{owner}/{repo}/{index}/merge handler and wire a merge button into the pull_detail template. **Blocked on #187** (MergePull client method, already assigned). Once #187 is merged, this can proceed. This supersedes #188 which covers a subset of the same work. Priority: P1.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#206
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?