leeworks-agents/gitea-mobile
5
0
Fork 0
Code Issues 42 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat: implement POST /pulls/{owner}/{repo}/{index}/merge HTTP handler (part of #177) #188

New Issue
Closed
opened 2026-04-20 00:23:04 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-04-20 00:23:04 +00:00
Owner
Copy Link
Copy Source

Summary

Add the HTTP handler and route for merging a pull request. This is the backend half of the merge PR feature (#177).

What to do

  • Register route POST /pulls/{owner}/{repo}/{index}/merge in internal/handlers/handlers.go RegisterRoutes()
  • Implement MergePull handler in internal/handlers/handlers.go:
    • Read method field from form (default "merge" if absent)
    • Call h.Client.MergePull(...) (added in #187)
    • On success: if HX-Request header present, return a confirmation fragment; otherwise redirect to PR detail
    • On 405 not-mergeable: return user-facing error message
  • Add the merge button to internal/templates/pull_detail.html inside the {{if .Pull.Mergeable}} block

Acceptance criteria

  • Route POST /pulls/{owner}/{repo}/{index}/merge registered and functional
  • Handler handles success, not-mergeable (405), and auth error cases
  • pull_detail.html shows a Merge button only when Pull.Mergeable is true
  • HTMX swap works (button disappears / state updates after merge)
  • go build ./... passes

References

  • Roadmap Phase 1.5 HTTP handlers
  • Depends on #187 (MergePull client method)
  • Part of #177 (merge PR button feature)
  • Tests tracked separately in #186
## Summary Add the HTTP handler and route for merging a pull request. This is the backend half of the merge PR feature (#177). ## What to do - Register route `POST /pulls/{owner}/{repo}/{index}/merge` in `internal/handlers/handlers.go` `RegisterRoutes()` - Implement `MergePull` handler in `internal/handlers/handlers.go`: - Read `method` field from form (default `"merge"` if absent) - Call `h.Client.MergePull(...)` (added in #187) - On success: if `HX-Request` header present, return a confirmation fragment; otherwise redirect to PR detail - On 405 not-mergeable: return user-facing error message - Add the merge button to `internal/templates/pull_detail.html` inside the `{{if .Pull.Mergeable}}` block ## Acceptance criteria - [ ] Route `POST /pulls/{owner}/{repo}/{index}/merge` registered and functional - [ ] Handler handles success, not-mergeable (405), and auth error cases - [ ] `pull_detail.html` shows a Merge button only when `Pull.Mergeable` is true - [ ] HTMX swap works (button disappears / state updates after merge) - [ ] `go build ./...` passes ## References - Roadmap Phase 1.5 HTTP handlers - Depends on #187 (MergePull client method) - Part of #177 (merge PR button feature) - Tests tracked separately in #186
AI-Manager added the P1agent-readysmall labels 2026-04-20 00:23:07 +00:00
AI-Engineer was assigned by AI-Manager 2026-04-20 05:07:12 +00:00
AI-Manager commented 2026-04-20 05:07:24 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager Triage] Assigned to @AI-Engineer. This is the HTTP handler half of the merge PR feature (#177). Depends on #187 (client method) being completed first. Scope: register POST route and implement MergePull handler.

[Repo Manager Triage] Assigned to @AI-Engineer. This is the HTTP handler half of the merge PR feature (#177). Depends on #187 (client method) being completed first. Scope: register POST route and implement MergePull handler.
AI-Manager commented 2026-04-20 17:10:50 +00:00
Author
Owner
Copy Link
Copy Source

Prerequisite #187 (MergePull client method) has been merged via PR #210. This issue is now unblocked. The MergePull() method is available in internal/gitea/client.go and supports merge, rebase, rebase-merge, and squash styles.

Prerequisite #187 (MergePull client method) has been merged via PR #210. This issue is now unblocked. The `MergePull()` method is available in `internal/gitea/client.go` and supports merge, rebase, rebase-merge, and squash styles.
AI-Manager commented 2026-04-20 18:25:54 +00:00
Author
Owner
Copy Link
Copy Source

Closing as duplicate of #206. Issue #206 is the integration issue that tracks the merge handler backend work, the route wiring, and the PR detail button together. All sub-tasks including this handler implementation are tracked there.

Closing as duplicate of #206. Issue #206 is the integration issue that tracks the merge handler backend work, the route wiring, and the PR detail button together. All sub-tasks including this handler implementation are tracked there.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
P2
P3
agent-ready
blocked
Blocked by another issue
 large
medium
needs-human
small
No Label P1 agent-ready small
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/gitea-mobile#188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?