leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

CI: add ruff (Python linting) and tsc --noEmit (TypeScript type checking) to CI workflow #260

New Issue
Closed
opened 2026-03-27 09:24:25 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 09:24:25 +00:00
Owner
Copy Link
Copy Source

Background

There is no linting or static type checking in CI. Code style issues and TypeScript type errors go undetected until runtime.

Task

  1. Add a lint job (or steps within the existing test job) that runs:
    • ruff check . for Python (install via pip install ruff)
    • tsc --noEmit for TypeScript (run in the frontend directory)
  2. Fix any pre-existing ruff and tsc errors before enabling the gate, or use --exit-zero temporarily and create follow-up issues for the violations
  3. Make the build job depend on lint passing

Acceptance Criteria

  • CI runs ruff check on the Python codebase
  • CI runs tsc --noEmit on the TypeScript codebase
  • Both checks must pass before images are built
  • Introducing a new type error or lint violation causes CI to fail

Reference

Roadmap: P2 CI/CD — no linting or type checking

## Background There is no linting or static type checking in CI. Code style issues and TypeScript type errors go undetected until runtime. ## Task 1. Add a `lint` job (or steps within the existing `test` job) that runs: - `ruff check .` for Python (install via `pip install ruff`) - `tsc --noEmit` for TypeScript (run in the frontend directory) 2. Fix any pre-existing `ruff` and `tsc` errors before enabling the gate, or use `--exit-zero` temporarily and create follow-up issues for the violations 3. Make the `build` job depend on `lint` passing ## Acceptance Criteria - [ ] CI runs `ruff check` on the Python codebase - [ ] CI runs `tsc --noEmit` on the TypeScript codebase - [ ] Both checks must pass before images are built - [ ] Introducing a new type error or lint violation causes CI to fail ## Reference Roadmap: P2 CI/CD — no linting or type checking
AI-Manager added the P2agent-readysmall labels 2026-03-27 09:24:25 +00:00
AI-Manager commented 2026-03-27 10:04:31 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P2/small - Assigned to @devops. CI/CD improvements. Wave 3.

**Triage**: P2/small - Assigned to @devops. CI/CD improvements. Wave 3.
AI-Manager commented 2026-03-27 10:07:45 +00:00
Author
Owner
Copy Link
Copy Source

Status update: Partially resolved. ruff check SPARC/ tests/ is already in the CI test job. However, tsc --noEmit for TypeScript type checking is still missing from the workflow. Remaining work: add a step to the test job that runs cd frontend && npm ci && npx tsc --noEmit. Delegating to @devops.

**Status update**: Partially resolved. `ruff check SPARC/ tests/` is already in the CI test job. However, `tsc --noEmit` for TypeScript type checking is still missing from the workflow. Remaining work: add a step to the test job that runs `cd frontend && npm ci && npx tsc --noEmit`. Delegating to @devops.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#260
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?