Add webhook integration tests covering retry logic and Slack/Discord payloads

22 test cases covering: - Slack/Discord URL detection - Generic vs Slack payload formatting - Exponential backoff retry logic with network/timeout error handling - Multi-URL dispatch with format auto-detection - notify_job_completed() and notify_alert() helpers Closes leeworks-agents/SPARC#1657 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-20 19:15:34 +00:00
2 changed files with 280 additions and 224 deletions
@@ -1,224 +0,0 @@
-"""Tests for export endpoints: CSV and PDF export of analysis results.
-
-Covers issue #1655:
- GET /export/{company_name} (CSV export)
- GET /export/{company_name}/pdf (PDF export)
-
-All tests mock the database layer and use JWT auth fixtures from test_auth patterns.
-"""
-
-from datetime import datetime, timezone
-from unittest.mock import MagicMock, patch
-
-import pytest
-from fastapi.testclient import TestClient
-
-from SPARC.api import app
-from SPARC.auth import create_access_token
-
-
-@pytest.fixture
-def client():
-    """Create test client."""
-    return TestClient(app)
-
-
-@pytest.fixture(autouse=True)
-def mock_db():
-    """Mock the database client used by export and auth endpoints."""
-    db = MagicMock()
-
-    # Default: user exists for auth
-    db.get_user_by_id.return_value = {
-        "id": 1,
-        "email": "user@test.com",
-        "role": "user",
-        "created_at": datetime(2025, 1, 1, tzinfo=timezone.utc),
-    }
-
-    # Mock get_conn for export queries
-    mock_cursor = MagicMock()
-    mock_conn = MagicMock()
-    mock_conn.cursor.return_value.__enter__ = MagicMock(return_value=mock_cursor)
-    mock_conn.cursor.return_value.__exit__ = MagicMock(return_value=False)
-    db.get_conn.return_value.__enter__ = MagicMock(return_value=mock_conn)
-    db.get_conn.return_value.__exit__ = MagicMock(return_value=False)
-    db._mock_cursor = mock_cursor
-
-    with patch("SPARC.api.get_db_client", return_value=db), \
-         patch("SPARC.auth.get_db_client", return_value=db):
-        yield db
-
-
-def _auth_header():
-    """Create an Authorization header with a valid access token."""
-    token = create_access_token(1, "user@test.com", "user")
-    return {"Authorization": f"Bearer {token}"}
-
-
-def _sample_rows():
-    """Return sample llm_messages rows as tuples (matching cursor.fetchall format)."""
-    return [
-        (
-            "NVIDIA",
-            "company_analysis",
-            "anthropic/claude-3.5-sonnet",
-            "Strong AI patent portfolio with focus on GPU architectures.",
-            datetime(2025, 6, 15, 10, 30, 0),
-        ),
-        (
-            "NVIDIA",
-            "patent_analysis",
-            "openai/gpt-4o",
-            "Patent US-12345678-B2 covers novel tensor core design.",
-            datetime(2025, 6, 14, 9, 0, 0),
-        ),
-    ]
-
-
-class TestCSVExport:
-    """GET /export/{company_name} -- CSV export."""
-
-    def test_csv_export_success(self, client, mock_db):
-        """Valid company with results returns a CSV file."""
-        mock_db._mock_cursor.fetchall.return_value = _sample_rows()
-
-        response = client.get("/export/NVIDIA", headers=_auth_header())
-
-        assert response.status_code == 200
-        assert response.headers["content-type"].startswith("text/csv")
-        assert "attachment" in response.headers.get("content-disposition", "")
-        assert "sparc_nvidia_export.csv" in response.headers["content-disposition"]
-
-        # Verify CSV content (CSV uses \r\n line endings)
-        lines = response.text.strip().split("\n")
-        assert len(lines) == 3  # header + 2 data rows
-        assert lines[0].strip() == "company_name,analysis_type,model,analysis,timestamp"
-        assert "NVIDIA" in lines[1]
-        assert "company_analysis" in lines[1]
-
-    def test_csv_export_no_results_returns_404(self, client, mock_db):
-        """Unknown company returns 404."""
-        mock_db._mock_cursor.fetchall.return_value = []
-
-        response = client.get("/export/nonexistent", headers=_auth_header())
-
-        assert response.status_code == 404
-        assert "No analysis results found" in response.json()["detail"]
-
-    def test_csv_export_unauthenticated_returns_401(self, client):
-        """Request without token returns 401."""
-        response = client.get("/export/NVIDIA")
-        assert response.status_code == 401
-
-    def test_csv_export_invalid_token_returns_401(self, client):
-        """Request with invalid token returns 401."""
-        response = client.get(
-            "/export/NVIDIA",
-            headers={"Authorization": "Bearer invalid.token.here"},
-        )
-        assert response.status_code == 401
-
-    def test_csv_export_filename_sanitization(self, client, mock_db):
-        """Company names with spaces get sanitized in the filename."""
-        mock_db._mock_cursor.fetchall.return_value = [
-            (
-                "Tesla Motors",
-                "company_analysis",
-                "anthropic/claude-3.5-sonnet",
-                "EV patent portfolio analysis.",
-                datetime(2025, 6, 15, 10, 0, 0),
-            ),
-        ]
-
-        response = client.get("/export/Tesla Motors", headers=_auth_header())
-
-        assert response.status_code == 200
-        assert "tesla_motors" in response.headers["content-disposition"]
-
-    def test_csv_export_single_row(self, client, mock_db):
-        """Single analysis result produces valid CSV with one data row."""
-        mock_db._mock_cursor.fetchall.return_value = [_sample_rows()[0]]
-
-        response = client.get("/export/NVIDIA", headers=_auth_header())
-
-        assert response.status_code == 200
-        lines = response.text.strip().split("\n")
-        assert len(lines) == 2  # header + 1 data row
-
-
-class TestPDFExport:
-    """GET /export/{company_name}/pdf -- PDF report export."""
-
-    def test_pdf_export_success(self, client, mock_db):
-        """Valid company with results returns a PDF file."""
-        mock_db._mock_cursor.fetchall.return_value = _sample_rows()
-
-        response = client.get("/export/NVIDIA/pdf", headers=_auth_header())
-
-        assert response.status_code == 200
-        assert response.headers["content-type"] == "application/pdf"
-        assert "attachment" in response.headers.get("content-disposition", "")
-        # PDF files start with %PDF
-        assert response.content[:4] == b"%PDF"
-
-    def test_pdf_export_no_results_returns_404(self, client, mock_db):
-        """Unknown company returns 404."""
-        mock_db._mock_cursor.fetchall.return_value = []
-
-        response = client.get("/export/nonexistent/pdf", headers=_auth_header())
-
-        assert response.status_code == 404
-        assert "No analysis results found" in response.json()["detail"]
-
-    def test_pdf_export_unauthenticated_returns_401(self, client):
-        """Request without token returns 401."""
-        response = client.get("/export/NVIDIA/pdf")
-        assert response.status_code == 401
-
-    def test_pdf_export_invalid_token_returns_401(self, client):
-        """Request with invalid token returns 401."""
-        response = client.get(
-            "/export/NVIDIA/pdf",
-            headers={"Authorization": "Bearer invalid.token.here"},
-        )
-        assert response.status_code == 401
-
-    def test_pdf_export_filename_contains_date(self, client, mock_db):
-        """PDF filename includes the analysis date."""
-        mock_db._mock_cursor.fetchall.return_value = _sample_rows()
-
-        response = client.get("/export/NVIDIA/pdf", headers=_auth_header())
-
-        assert response.status_code == 200
-        disposition = response.headers["content-disposition"]
-        assert "nvidia-analysis-" in disposition
-        assert ".pdf" in disposition
-
-    def test_pdf_export_special_chars_in_response(self, client, mock_db):
-        """Analysis text with XML-special chars (<, >, &) does not break PDF generation."""
-        rows = [
-            (
-                "TestCo",
-                "company_analysis",
-                "anthropic/claude-3.5-sonnet",
-                "Revenue > $1B & growth <20% for Q4. Test <html> escaping.",
-                datetime(2025, 6, 15, 10, 0, 0),
-            ),
-        ]
-        mock_db._mock_cursor.fetchall.return_value = rows
-
-        response = client.get("/export/TestCo/pdf", headers=_auth_header())
-
-        assert response.status_code == 200
-        assert response.content[:4] == b"%PDF"
-
-    def test_pdf_export_multiple_analyses(self, client, mock_db):
-        """Multiple analysis records produce a valid PDF with content."""
-        mock_db._mock_cursor.fetchall.return_value = _sample_rows()
-
-        response = client.get("/export/NVIDIA/pdf", headers=_auth_header())
-
-        assert response.status_code == 200
-        # PDF should have reasonable size (more than just headers)
-        assert len(response.content) > 500
@@ -0,0 +1,280 @@
+"""Tests for webhook notification system: retry logic and Slack/Discord payload format.
+
+Covers issue #1657:
+- Retry logic with exponential backoff in _send_with_retry
+- Slack/Discord payload formatting in _build_payload
+- Generic HTTP POST payload formatting
+- notify() dispatching to multiple URLs
+- notify_job_completed() and notify_alert() convenience helpers
+"""
+
+from datetime import datetime
+from unittest.mock import MagicMock, patch, call
+
+import pytest
+import requests
+
+from SPARC.webhooks import (
+    MAX_RETRIES,
+    _build_payload,
+    _is_slack_url,
+    _send_with_retry,
+    notify,
+    notify_alert,
+    notify_job_completed,
+)
+
+
+class TestIsSlackUrl:
+    """Tests for Slack/Discord URL detection."""
+
+    def test_slack_webhook_url(self):
+        assert _is_slack_url("https://hooks.slack.com/services/T00/B00/xxx") is True
+
+    def test_discord_webhook_url(self):
+        assert _is_slack_url("https://discord.com/api/webhooks/123/abc") is True
+
+    def test_generic_url(self):
+        assert _is_slack_url("https://example.com/webhook") is False
+
+    def test_empty_url(self):
+        assert _is_slack_url("") is False
+
+
+class TestBuildPayload:
+    """Tests for payload construction."""
+
+    def test_generic_payload_structure(self):
+        """Generic payload includes event type, timestamp, and data."""
+        payload = _build_payload("job_completed", {"job_id": "abc123"})
+
+        assert payload["event"] == "job_completed"
+        assert payload["job_id"] == "abc123"
+        assert "timestamp" in payload
+        # Timestamp should be ISO format ending with Z
+        assert payload["timestamp"].endswith("Z")
+
+    def test_slack_payload_wraps_in_text(self):
+        """Slack payload wraps content in a 'text' field."""
+        payload = _build_payload("patent_alert", {"company_name": "NVIDIA"}, slack=True)
+
+        assert "text" in payload
+        assert "patent_alert" in payload["text"]
+        assert "NVIDIA" in payload["text"]
+        # Slack payload should NOT have the event/timestamp at top level
+        assert "event" not in payload
+        assert "timestamp" not in payload
+
+    def test_generic_payload_does_not_have_text_field(self):
+        """Non-Slack payload does not wrap in text."""
+        payload = _build_payload("job_completed", {"status": "done"})
+
+        assert "text" not in payload
+        assert payload["status"] == "done"
+
+    def test_slack_payload_contains_bold_header(self):
+        """Slack payload starts with bold event header using Slack markdown."""
+        payload = _build_payload("job_completed", {"count": 5}, slack=True)
+
+        assert payload["text"].startswith("*[SPARC] job_completed*")
+
+    def test_payload_merges_all_data_keys(self):
+        """All data keys are included in the generic payload."""
+        data = {"key1": "val1", "key2": 42, "key3": True}
+        payload = _build_payload("test_event", data)
+
+        assert payload["key1"] == "val1"
+        assert payload["key2"] == 42
+        assert payload["key3"] is True
+
+
+class TestSendWithRetry:
+    """Tests for retry logic in _send_with_retry."""
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_success_on_first_attempt(self, mock_post, mock_sleep):
+        """Successful delivery on first attempt, no retries."""
+        mock_post.return_value = MagicMock(status_code=200)
+
+        result = _send_with_retry("https://example.com/hook", {"event": "test"})
+
+        assert result is True
+        mock_post.assert_called_once()
+        mock_sleep.assert_not_called()
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_success_on_second_attempt(self, mock_post, mock_sleep):
+        """Fails first, succeeds on retry."""
+        mock_post.side_effect = [
+            MagicMock(status_code=500),
+            MagicMock(status_code=200),
+        ]
+
+        result = _send_with_retry("https://example.com/hook", {"event": "test"})
+
+        assert result is True
+        assert mock_post.call_count == 2
+        mock_sleep.assert_called_once()
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_all_retries_exhausted(self, mock_post, mock_sleep):
+        """Returns False after all retries fail."""
+        mock_post.return_value = MagicMock(status_code=500)
+
+        result = _send_with_retry("https://example.com/hook", {"event": "test"})
+
+        assert result is False
+        assert mock_post.call_count == MAX_RETRIES
+        assert mock_sleep.call_count == MAX_RETRIES - 1
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_exponential_backoff_timing(self, mock_post, mock_sleep):
+        """Backoff wait times follow exponential pattern (2^attempt)."""
+        mock_post.return_value = MagicMock(status_code=500)
+
+        _send_with_retry("https://example.com/hook", {"event": "test"})
+
+        # With BACKOFF_BASE=2: attempt 1 -> sleep(2), attempt 2 -> sleep(4)
+        expected_waits = [call(2 ** i) for i in range(1, MAX_RETRIES)]
+        assert mock_sleep.call_args_list == expected_waits
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_network_error_triggers_retry(self, mock_post, mock_sleep):
+        """Network exceptions trigger retry, not immediate failure."""
+        mock_post.side_effect = [
+            requests.ConnectionError("Connection refused"),
+            MagicMock(status_code=200),
+        ]
+
+        result = _send_with_retry("https://example.com/hook", {"event": "test"})
+
+        assert result is True
+        assert mock_post.call_count == 2
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_timeout_error_triggers_retry(self, mock_post, mock_sleep):
+        """Timeout exceptions trigger retry."""
+        mock_post.side_effect = [
+            requests.Timeout("Request timed out"),
+            MagicMock(status_code=200),
+        ]
+
+        result = _send_with_retry("https://example.com/hook", {"event": "test"})
+
+        assert result is True
+        assert mock_post.call_count == 2
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_2xx_status_codes_accepted(self, mock_post, mock_sleep):
+        """Any 2xx status code is treated as success."""
+        mock_post.return_value = MagicMock(status_code=204)
+
+        result = _send_with_retry("https://example.com/hook", {"event": "test"})
+
+        assert result is True
+        mock_post.assert_called_once()
+
+    @patch("SPARC.webhooks.time.sleep")
+    @patch("SPARC.webhooks.requests.post")
+    def test_posts_json_payload(self, mock_post, mock_sleep):
+        """Payload is sent as JSON with correct timeout."""
+        mock_post.return_value = MagicMock(status_code=200)
+        payload = {"event": "test", "data": "value"}
+
+        _send_with_retry("https://example.com/hook", payload)
+
+        mock_post.assert_called_once_with(
+            "https://example.com/hook", json=payload, timeout=10
+        )
+
+
+class TestNotify:
+    """Tests for the notify() dispatcher."""
+
+    @patch("SPARC.webhooks._send_with_retry")
+    @patch("SPARC.webhooks.WEBHOOK_URLS", ["https://example.com/hook1", "https://example.com/hook2"])
+    def test_dispatches_to_all_urls(self, mock_send):
+        """notify() sends to every configured webhook URL."""
+        mock_send.return_value = True
+
+        notify("job_completed", {"job_id": "test123"})
+
+        assert mock_send.call_count == 2
+
+    @patch("SPARC.webhooks._send_with_retry")
+    @patch("SPARC.webhooks.WEBHOOK_URLS", [])
+    def test_no_urls_configured_returns_immediately(self, mock_send):
+        """No-op when no webhook URLs are configured."""
+        notify("job_completed", {"job_id": "test123"})
+
+        mock_send.assert_not_called()
+
+    @patch("SPARC.webhooks._send_with_retry")
+    @patch("SPARC.webhooks.WEBHOOK_URLS", [
+        "https://hooks.slack.com/services/T00/B00/xxx",
+        "https://example.com/generic",
+    ])
+    def test_slack_url_gets_slack_payload(self, mock_send):
+        """Slack URLs receive Slack-formatted payloads, others get generic."""
+        mock_send.return_value = True
+
+        notify("test_event", {"key": "val"})
+
+        # First call (Slack URL) should have "text" key
+        slack_payload = mock_send.call_args_list[0][0][1]
+        assert "text" in slack_payload
+
+        # Second call (generic URL) should have "event" key
+        generic_payload = mock_send.call_args_list[1][0][1]
+        assert "event" in generic_payload
+        assert generic_payload["event"] == "test_event"
+
+
+class TestNotifyJobCompleted:
+    """Tests for notify_job_completed() convenience function."""
+
+    @patch("SPARC.webhooks.notify")
+    def test_sends_correct_event_and_data(self, mock_notify):
+        """Job completion sends proper event type and summary."""
+        notify_job_completed(
+            job_id="batch-001",
+            status="completed",
+            total_companies=10,
+            successful=8,
+            failed=2,
+        )
+
+        mock_notify.assert_called_once()
+        event, data = mock_notify.call_args[0]
+        assert event == "job_completed"
+        assert data["job_id"] == "batch-001"
+        assert data["successful"] == 8
+        assert data["failed"] == 2
+        assert "8/10" in data["summary"]
+
+
+class TestNotifyAlert:
+    """Tests for notify_alert() convenience function."""
+
+    @patch("SPARC.webhooks.notify")
+    def test_sends_correct_event_and_data(self, mock_notify):
+        """Alert notification sends patent_alert event type."""
+        notify_alert(
+            company_name="NVIDIA",
+            alert_type="patent_count_change",
+            message="Patent count increased by 30%",
+        )
+
+        mock_notify.assert_called_once()
+        event, data = mock_notify.call_args[0]
+        assert event == "patent_alert"
+        assert data["company_name"] == "NVIDIA"
+        assert data["alert_type"] == "patent_count_change"
+        assert "30%" in data["message"]